Patchwork Obvious: Fix DF solution dirty marking in cfg.c:disconnect_src

login
register
mail settings
Submitter Steven Bosscher
Date April 27, 2012, 9:18 a.m.
Message ID <CABu31nNO8WWXQV625pQqzifAXEY_UKORmXPyZQV2FU172B-DeA@mail.gmail.com>
Download mbox | patch
Permalink /patch/155401/
State New
Headers show

Comments

Steven Bosscher - April 27, 2012, 9:18 a.m.
Hello,

It makes no sense to mark DF solutions dirty on the gcc_unreachable()
path but not on the return path.

Bootstrapped&tested on x86_64-unknown-linux-gnu and
powerpc64-unknown-linux-gnu. I'll this, as obvious, some time late
next week unless I hear objections.

Ciao!
Steven


	* cfg.c (disconnect_src): Do df_mark_solutions_dirty in the right place.
Paolo Bonzini - April 27, 2012, 9:47 a.m.
Il 27/04/2012 11:18, Steven Bosscher ha scritto:
> Hello,
> 
> It makes no sense to mark DF solutions dirty on the gcc_unreachable()
> path but not on the return path.
> 
> Bootstrapped&tested on x86_64-unknown-linux-gnu and
> powerpc64-unknown-linux-gnu. I'll this, as obvious, some time late
> next week unless I hear objections.

Ok.

Paolo

Patch

Index: cfg.c
===================================================================
--- cfg.c	(revision 186897)
+++ cfg.c	(working copy)
@@ -242,13 +242,13 @@  disconnect_src (edge e)
       if (tmp == e)
 	{
 	  VEC_unordered_remove (edge, src->succs, ei.index);
+	  df_mark_solutions_dirty ();
 	  return;
 	}
       else
 	ei_next (&ei);
     }

-  df_mark_solutions_dirty ();
   gcc_unreachable ();
 }