From patchwork Fri Apr 27 07:01:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li RongQing X-Patchwork-Id: 155390 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8C078B6EF3 for ; Fri, 27 Apr 2012 17:01:30 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756698Ab2D0HB2 (ORCPT ); Fri, 27 Apr 2012 03:01:28 -0400 Received: from mail-pz0-f51.google.com ([209.85.210.51]:65441 "EHLO mail-pz0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755508Ab2D0HB1 (ORCPT ); Fri, 27 Apr 2012 03:01:27 -0400 Received: by mail-pz0-f51.google.com with SMTP id z8so605612dad.10 for ; Fri, 27 Apr 2012 00:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; bh=0iNUaUF0L1OwIPGxX87r8iM4c39YgPntrmKjdRYG07s=; b=EJq5ed362ij4k/VBdft0KdO6iB9uHYRc694aq5CShKe/Qnms6sB8Hm5VXr86rqlPUD siYKrKdiPtWjvRMtKLYw1Ju9ZNd2h4JzQdxSRMdCjAHB0zXpmcTF8865zN7ATSp3AzwN sdWiEQb1WcFAoNuJC/an4ow6243/BlI4jGjyBRtuvp4NpYpLLie5wZgStW0NITLOI52A TdpCcZiEJHyk9//8j19O0EBqUX9JV2TXXYXnxwAHMvOc4GiNZyeVVJoGQacaj6UAXbXY oao535pln+7TLC1dP5JRJUWQ5HHqotqjxWwLt8OQr8pkci7RNp1Txo95toZjercVb6gM fegw== Received: by 10.68.239.99 with SMTP id vr3mr1457158pbc.10.1335510087483; Fri, 27 Apr 2012 00:01:27 -0700 (PDT) Received: from localhost ([61.148.56.138]) by mx.google.com with ESMTPS id 2sm5617947pbw.57.2012.04.27.00.01.24 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Apr 2012 00:01:27 -0700 (PDT) From: roy.qing.li@gmail.com To: netdev@vger.kernel.org Subject: [PATCH net-next 2/2] drivers/net/oki-semi: Donot recompute IP header checksum Date: Fri, 27 Apr 2012 15:01:13 +0800 Message-Id: <1335510073-14018-2-git-send-email-roy.qing.li@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1335510073-14018-1-git-send-email-roy.qing.li@gmail.com> References: <1335510073-14018-1-git-send-email-roy.qing.li@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: RongQing.Li If I understand correct, NETIF_F_IP_CSUM only means the hardware will compute the TCP/UDP checksum, IP checksum is always computed in software So as a workround of hardware unable to compute small packages checksum, do not need to compute IP header checksum. Signed-off-by: RongQing.Li --- .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 835e3bb..107f41a 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c @@ -1240,8 +1240,6 @@ static void pch_gbe_tx_queue(struct pch_gbe_adapter *adapter, if (skb->protocol == htons(ETH_P_IP)) { struct iphdr *iph = ip_hdr(skb); unsigned int offset; - iph->check = 0; - iph->check = ip_fast_csum((u8 *) iph, iph->ihl); offset = skb_transport_offset(skb); if (iph->protocol == IPPROTO_TCP) { skb->csum = 0;