Patchwork qapi: fix qmp_balloon() conversion

login
register
mail settings
Submitter Luiz Capitulino
Date April 26, 2012, 9:07 p.m.
Message ID <20120426180741.1db9875a@doriath.home>
Download mbox | patch
Permalink /patch/155333/
State New
Headers show

Comments

Luiz Capitulino - April 26, 2012, 9:07 p.m.
Commit d72f326431 forgot to convert a call from qerror_report() to
error_set(). Fix it.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 balloon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Michael Roth - April 26, 2012, 9:38 p.m.
On Thu, Apr 26, 2012 at 06:07:41PM -0300, Luiz Capitulino wrote:
> Commit d72f326431 forgot to convert a call from qerror_report() to
> error_set(). Fix it.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  balloon.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/balloon.c b/balloon.c
> index 0166744..aa354f7 100644
> --- a/balloon.c
> +++ b/balloon.c
> @@ -108,7 +108,7 @@ void qmp_balloon(int64_t value, Error **errp)
>      }
> 
>      if (value <= 0) {
> -        qerror_report(QERR_INVALID_PARAMETER_VALUE, "target", "a size");
> +        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size");
>          return;
>      }
>      
> -- 
> 1.7.9.2.384.g4a92a
> 
>

Patch

diff --git a/balloon.c b/balloon.c
index 0166744..aa354f7 100644
--- a/balloon.c
+++ b/balloon.c
@@ -108,7 +108,7 @@  void qmp_balloon(int64_t value, Error **errp)
     }
 
     if (value <= 0) {
-        qerror_report(QERR_INVALID_PARAMETER_VALUE, "target", "a size");
+        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size");
         return;
     }