Patchwork IPVS: ip_vs_proto.c: local functions should not be exposed globally

mail settings
Submitter hartleys
Date April 26, 2012, 6:26 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/155311/
State Not Applicable
Delegated to: David Miller
Headers show


hartleys - April 26, 2012, 6:26 p.m.
Functions not referenced outside of a source file should be marked
static to prevent it from being exposed globally.

This quiets the sparse warnings:

warning: symbol '__ipvs_proto_data_get' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <>
Cc: "David S. Miller" <>


To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at


diff --git a/net/netfilter/ipvs/ip_vs_proto.c b/net/netfilter/ipvs/ip_vs_proto.c
index 6eda11d..d5d1d92 100644
--- a/net/netfilter/ipvs/ip_vs_proto.c
+++ b/net/netfilter/ipvs/ip_vs_proto.c
@@ -153,7 +153,7 @@  EXPORT_SYMBOL(ip_vs_proto_get);
  *	get ip_vs_protocol object data by netns and proto
-struct ip_vs_proto_data *
+static struct ip_vs_proto_data *
 __ipvs_proto_data_get(struct netns_ipvs *ipvs, unsigned short proto)
 	struct ip_vs_proto_data *pd;