Patchwork configure: Don't build bsd-user on Mac OS X by default

login
register
mail settings
Submitter Andreas Färber
Date April 26, 2012, 9:57 a.m.
Message ID <1335434259-41302-1-git-send-email-andreas.faerber@web.de>
Download mbox | patch
Permalink /patch/155218/
State New
Headers show

Comments

Andreas Färber - April 26, 2012, 9:57 a.m.
Fixes the build when combined with the drop of darwin-user.
Enthusiasts can still try building it using --enable-bsd-user.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Bernhard Walle <bernhard@bwalle.de>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Bernhard Walle - April 26, 2012, 10:30 a.m.
Am 26.04.12 11:57, schrieb Andreas Färber:
> Fixes the build when combined with the drop of darwin-user.
> Enthusiasts can still try building it using --enable-bsd-user.
> 
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> Cc: Bernhard Walle <bernhard@bwalle.de>

Thanks. I already stumbled over this when trying to test your
uint16 fixes (they work for me, BTW).


Regards,
Bernhard
Andreas Färber - April 26, 2012, 12:50 p.m.
Am 26.04.2012 12:30, schrieb Bernhard Walle:
> Am 26.04.12 11:57, schrieb Andreas Färber:
>> Fixes the build when combined with the drop of darwin-user.
>> Enthusiasts can still try building it using --enable-bsd-user.
>>
>> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
>> Cc: Bernhard Walle <bernhard@bwalle.de>
> 
> Thanks. I already stumbled over this when trying to test your
> uint16 fixes (they work for me, BTW).

In that case please add an appropriate tag (e.g., Tested-by) as reply
there (best with info on what architecture and OS version you tested).
Otherwise there's no telling whether no one looked at it, and they will
bitrot again like in January and before that. Patch review and reacting
to patch reviews are the weak spot of Mac OS X host support, sadly.

If you add an Acked-by to this one, I can send a PULL for this and
darwin-user removal right away. uint16 touches all hosts and virtually
all guests so needs more review than the Darwin-only changes.

Regards,
Andreas
Bernhard Walle - April 26, 2012, 1:47 p.m.
Am 26.04.12 11:57, schrieb Andreas Färber:
> Fixes the build when combined with the drop of darwin-user.
> Enthusiasts can still try building it using --enable-bsd-user.
> 
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> Cc: Bernhard Walle <bernhard@bwalle.de>

Tested-by: Bernhard Walle <bernhard@bwalle.de> [Mac OS 10.7.3]
Acked-by: Bernhard Walle <bernhard@bwalle.de>
Bernhard Walle - April 26, 2012, 1:53 p.m.
Am 26.04.12 14:50, schrieb Andreas Färber:
> Am 26.04.2012 12:30, schrieb Bernhard Walle:
>>
>> Thanks. I already stumbled over this when trying to test your
>> uint16 fixes (they work for me, BTW).
> 
> In that case please add an appropriate tag (e.g., Tested-by) as reply
> there (best with info on what architecture and OS version you tested).
> Otherwise there's no telling whether no one looked at it, and they will
> bitrot again like in January and before that. Patch review and reacting
> to patch reviews are the weak spot of Mac OS X host support, sadly.
> 
> If you add an Acked-by to this one, I can send a PULL for this and
> darwin-user removal right away. uint16 touches all hosts and virtually
> all guests so needs more review than the Darwin-only changes.

Thanks for the hint. Hope my replies are ok now.

I thought Acked-by is only for experts...


Regards,
Bernhard
Blue Swirl - April 28, 2012, 11:45 a.m.
On Thu, Apr 26, 2012 at 09:57, Andreas Färber <andreas.faerber@web.de> wrote:
> Fixes the build when combined with the drop of darwin-user.
> Enthusiasts can still try building it using --enable-bsd-user.
>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> Cc: Bernhard Walle <bernhard@bwalle.de>

Thanks, applied.

> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index dd09f1a..e1bdc10 100755
> --- a/configure
> +++ b/configure
> @@ -498,8 +498,8 @@ esac
>  if [ "$bsd" = "yes" ] ; then
>   if [ "$darwin" != "yes" ] ; then
>     usb="bsd"
> +    bsd_user="yes"
>   fi
> -  bsd_user="yes"
>  fi
>
>  : ${make=${MAKE-make}}
> --
> 1.7.5.3
>
>

Patch

diff --git a/configure b/configure
index dd09f1a..e1bdc10 100755
--- a/configure
+++ b/configure
@@ -498,8 +498,8 @@  esac
 if [ "$bsd" = "yes" ] ; then
   if [ "$darwin" != "yes" ] ; then
     usb="bsd"
+    bsd_user="yes"
   fi
-  bsd_user="yes"
 fi
 
 : ${make=${MAKE-make}}