From patchwork Thu Apr 26 06:27:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Xiong" X-Patchwork-Id: 155162 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 895DDB6F9D for ; Thu, 26 Apr 2012 16:29:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522Ab2DZG3E (ORCPT ); Thu, 26 Apr 2012 02:29:04 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:21619 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754161Ab2DZG3B (ORCPT ); Thu, 26 Apr 2012 02:29:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=xiong@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1335421741; x=1366957741; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=wMAcdr3z4kT/8QV+Wn0bYEc1aSgdpEBhlUiX8Mrch70=; b=F3gtIUqvClkfPuZ2lrV/Kum8xim8W4jFZeAukFWgagM+pyKcncwoaDxL Lra89c+HdX4p4aHadsW/TqfOf7ArlBdashOOM51mw4kXhck/8YeSqYu2V 0WQ8A2BznU4zp0cG96yVBdDoFec9UcUN7ElPkkkK+tdjCrq7j87nvjWzE 4=; X-IronPort-AV: E=McAfee;i="5400,1158,6692"; a="185052131" Received: from ironmsg03-l.qualcomm.com ([172.30.48.18]) by wolverine01.qualcomm.com with ESMTP; 25 Apr 2012 23:29:00 -0700 X-IronPort-AV: E=Sophos;i="4.75,484,1330934400"; d="scan'208";a="229253379" Received: from nasanexhc08.na.qualcomm.com ([172.30.39.7]) by Ironmsg03-L.qualcomm.com with ESMTP/TLS/AES128-SHA; 25 Apr 2012 23:29:00 -0700 Received: from qcmail1.qualcomm.com (172.30.39.5) by qcmail1.qualcomm.com (172.30.39.7) with Microsoft SMTP Server (TLS) id 14.2.283.3; Wed, 25 Apr 2012 23:28:59 -0700 Received: by qcmail1.qualcomm.com (sSMTP sendmail emulation); Thu, 26 Apr 2012 14:28:55 +0800 From: xiong To: , , CC: , , xiong Subject: [PATCH 07/10] atl1c: remove PHY reset/init for link down event Date: Thu, 26 Apr 2012 14:27:15 +0800 Message-ID: <1335421638-16304-8-git-send-email-xiong@qca.qualcomm.com> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1335421638-16304-1-git-send-email-xiong@qca.qualcomm.com> References: <1335421638-16304-1-git-send-email-xiong@qca.qualcomm.com> MIME-Version: 1.0 X-Originating-IP: [172.30.39.5] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org it's unnecessary to reset/init phy when link down. Only L1/L2 chip (supported by atlx) need such action. Signed-off-by: xiong Tested-by: Liu David --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index 995da22..cb3b3c4 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -270,8 +270,6 @@ static void atl1c_check_link_status(struct atl1c_adapter *adapter) atl1c_set_aspm(hw, SPEED_0); netif_carrier_off(netdev); netif_stop_queue(netdev); - atl1c_phy_reset(hw); - atl1c_phy_init(&adapter->hw); } else { /* Link Up */ hw->hibernate = false;