Patchwork [U-Boot,2/4] patman: Add meaningful statements instead of blah blah

login
register
mail settings
Submitter Vikram Narayanan
Date April 25, 2012, 3:45 p.m.
Message ID <4F981C10.5080602@gmail.com>
Download mbox | patch
Permalink /patch/155007/
State Superseded, archived
Delegated to: Anatolij Gustschin
Headers show

Comments

Vikram Narayanan - April 25, 2012, 3:45 p.m.
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
---
 tools/patman/README |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
Simon Glass - April 26, 2012, 6:01 p.m.
Hi Vikram,

On Thu, Apr 26, 2012 at 3:45 AM, Vikram Narayanan <vikram186@gmail.com>wrote:

> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
>

It would be better if you added a commit message for each of these patches,
even a brief one. Otherwise:

Acked-by: Simon Glass <sjg@chromium.org>


> ---
>  tools/patman/README |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tools/patman/README b/tools/patman/README
> index d9820ab..d98f081 100644
> --- a/tools/patman/README
> +++ b/tools/patman/README
> @@ -132,16 +132,15 @@ Series-prefix: prefix
>
>  Cover-letter:
>  This is the patch set title
> -blah blah
> -more blah blah
> +This patch set fixes the errors when CONFIG_xxx is enabled.
> +Tested on xyz board.
>  END
>        Sets the cover letter contents for the series. The first line
>        will become the subject of the cover letter
>
>  Series-notes:
> -blah blah
> -blah blah
> -more blah blah
> +Sorry that I couldn't find time to reply for the comments posted on the
> v1 of my
> +patch. This patch superseeds v1. Please comment.
>  END
>        Sets some notes for the patch series, which you don't want in
>        the commit messages, but do want to send, The notes are joined
> --
> 1.7.4.1
>
>

Patch

diff --git a/tools/patman/README b/tools/patman/README
index d9820ab..d98f081 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -132,16 +132,15 @@  Series-prefix: prefix
 
 Cover-letter:
 This is the patch set title
-blah blah
-more blah blah
+This patch set fixes the errors when CONFIG_xxx is enabled.
+Tested on xyz board.
 END
 	Sets the cover letter contents for the series. The first line
 	will become the subject of the cover letter
 
 Series-notes:
-blah blah
-blah blah
-more blah blah
+Sorry that I couldn't find time to reply for the comments posted on the v1 of my
+patch. This patch superseeds v1. Please comment.
 END
 	Sets some notes for the patch series, which you don't want in
 	the commit messages, but do want to send, The notes are joined