From patchwork Wed Apr 25 13:57:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Declare state directory in smb.conf Date: Wed, 25 Apr 2012 03:57:19 -0000 From: Nikolaus Rath X-Patchwork-Id: 154945 Message-Id: <87haw79ao0.fsf@inspiron.ap.columbia.edu> To: qemu-devel@nongnu.org The smb.conf generated by the userspace networking does not include a state directory directive. Samba therefore falls back to the default value. Since the user generally does not have write access to this path, smbd immediately crashes. The "state directory" option was added in Samba 3.4.0 (commit http://gitweb.samba.org/?p=samba.git;a=commit;h=7b02e05eb64f3ffd7aa1cf027d10a7343c0da757). This patch adds the missing option. Signed-off-by: Nikolaus Rath --- Best, -Nikolaus diff -r -u qemu-kvm-1.0.1.old/net/slirp.c qemu-kvm-1.0.1/net/slirp.c --- qemu-kvm-1.0.1.old/net/slirp.c 2012-04-16 22:15:17.000000000 -0400 +++ qemu-kvm-1.0.1/net/slirp.c 2012-04-24 21:56:41.835745642 -0400 @@ -511,6 +511,7 @@ "socket address=127.0.0.1\n" "pid directory=%s\n" "lock directory=%s\n" + "state directory=%s\n" "log file=%s/log.smbd\n" "smb passwd file=%s/smbpasswd\n" "security = share\n" @@ -521,6 +522,7 @@ s->smb_dir, s->smb_dir, s->smb_dir, + s->smb_dir, s->smb_dir, s->smb_dir, exported_dir