Patchwork [qemu,4/6] vl.c: change 'defconfig' variable to bool

login
register
mail settings
Submitter Eduardo Habkost
Date April 24, 2012, 8:32 p.m.
Message ID <1335299581-25009-5-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/154756/
State New
Headers show

Comments

Eduardo Habkost - April 24, 2012, 8:32 p.m.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 vl.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Blue Swirl - April 28, 2012, 7:53 a.m.
On Tue, Apr 24, 2012 at 20:32, Eduardo Habkost <ehabkost@redhat.com> wrote:
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 1e5e593..a4f4676 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2279,7 +2279,7 @@ int main(int argc, char **argv, char **envp)
>  #ifdef CONFIG_VNC
>     int show_vnc_port = 0;
>  #endif
> -    int defconfig = 1;
> +    int defconfig = true;

The type is still 'int', is that intentional?

>     const char *log_mask = NULL;
>     const char *log_file = NULL;
>     GMemVTable mem_trace = {
> @@ -2346,7 +2346,7 @@ int main(int argc, char **argv, char **envp)
>             popt = lookup_opt(argc, argv, &optarg, &optind);
>             switch (popt->index) {
>             case QEMU_OPTION_nodefconfig:
> -                defconfig=0;
> +                defconfig = false;
>                 break;
>             }
>         }
> --
> 1.7.3.2
>
>
Eduardo Habkost - April 30, 2012, 12:51 p.m.
On Sat, Apr 28, 2012 at 07:53:41AM +0000, Blue Swirl wrote:
> On Tue, Apr 24, 2012 at 20:32, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  vl.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index 1e5e593..a4f4676 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -2279,7 +2279,7 @@ int main(int argc, char **argv, char **envp)
> >  #ifdef CONFIG_VNC
> >     int show_vnc_port = 0;
> >  #endif
> > -    int defconfig = 1;
> > +    int defconfig = true;
> 
> The type is still 'int', is that intentional?

Oops! It was not, sorry. I will respin the series.

Patch

diff --git a/vl.c b/vl.c
index 1e5e593..a4f4676 100644
--- a/vl.c
+++ b/vl.c
@@ -2279,7 +2279,7 @@  int main(int argc, char **argv, char **envp)
 #ifdef CONFIG_VNC
     int show_vnc_port = 0;
 #endif
-    int defconfig = 1;
+    int defconfig = true;
     const char *log_mask = NULL;
     const char *log_file = NULL;
     GMemVTable mem_trace = {
@@ -2346,7 +2346,7 @@  int main(int argc, char **argv, char **envp)
             popt = lookup_opt(argc, argv, &optarg, &optind);
             switch (popt->index) {
             case QEMU_OPTION_nodefconfig:
-                defconfig=0;
+                defconfig = false;
                 break;
             }
         }