From patchwork Tue Apr 24 09:45:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Reinhard Tartler X-Patchwork-Id: 154636 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 469BFB6EE6 for ; Tue, 24 Apr 2012 19:58:19 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SMcTI-00040W-9n; Tue, 24 Apr 2012 09:55:44 +0000 Received: from faui45.informatik.uni-erlangen.de ([2001:638:a00:22::2d]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SMcTE-0003yK-W8 for linux-arm-kernel@lists.infradead.org; Tue, 24 Apr 2012 09:55:41 +0000 Received: from vamos2c.informatik.uni-erlangen.de (unknown [IPv6:2001:638:a00:2a:5054:ff:fe4e:4617]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by faui45.informatik.uni-erlangen.de (Postfix) with ESMTPS id 9ACB67419BF; Tue, 24 Apr 2012 11:45:40 +0200 (CEST) Received: from [2001:638:a00:22:1cd:458c:be1b:84f8] (helo=faui43f) by vamos2c.informatik.uni-erlangen.de with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1SMcJS-0000Xb-RI; Tue, 24 Apr 2012 11:45:39 +0200 Received: from siretart by faui43f with local (Exim 4.76) (envelope-from ) id 1SMcJV-0001gU-Cc; Tue, 24 Apr 2012 11:45:37 +0200 From: Reinhard Tartler To: Russell King , Rob Herring , Nicolas Pitre , Arnd Bergmann , Guan Xuetao , Ralf Baechle Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly Organization: Uni Erlangen, Informatik 4, Lehrstuhl =?utf-8?Q?f=C3=BCr?= Betriebs- und verteilte Systeme X-Url: http://www4.informatik.uni-erlangen.de/~tartler Date: Tue, 24 Apr 2012 11:45:37 +0200 Message-ID: <87vckpsbsu.fsf@faui43f.informatik.uni-erlangen.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: vamos-dev@lists.informatik.uni-erlangen.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Hi, with configration-aware static analysis, we have found a gcc warning that can be fixed easily. Please consider applying the following patch (based on v3.4-rc4). From 4fd3be96ed8d35d9825d833623ddd69485ddc5ba Mon Sep 17 00:00:00 2001 From: Reinhard Tartler Date: Tue, 24 Apr 2012 11:35:16 +0200 Subject: [PATCH] ARM: arch/arm/mach-shark/pci.c: signal errors correctly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes the following gcc warning: arch/arm/mach-shark/pci.c:42: warning: ‘return’ with no value, in function returning non-void Signed-off-by: Reinhard Tartler --- arch/arm/mach-shark/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-shark/pci.c b/arch/arm/mach-shark/pci.c index 7cb79a0..12fcc47 100644 --- a/arch/arm/mach-shark/pci.c +++ b/arch/arm/mach-shark/pci.c @@ -39,7 +39,7 @@ static struct hw_pci shark_pci __initdata = { static int __init shark_pci_init(void) { if (!machine_is_shark()) - return; + return 1; pcibios_min_io = 0x6000; pcibios_min_mem = 0x50000000;