Patchwork [v2] smsc95xx: mark link down on startup and let PHY interrupt deal with carrier changes

login
register
mail settings
Submitter Paolo Pisati
Date April 23, 2012, 2:05 p.m.
Message ID <1335189920-31062-1-git-send-email-paolo.pisati@canonical.com>
Download mbox | patch
Permalink /patch/154456/
State Accepted
Delegated to: David Miller
Headers show

Comments

Paolo Pisati - April 23, 2012, 2:05 p.m.
Without this patch sysfs reports the cable as present

flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
1

while it's not:

flag@flag-desktop:~$ sudo mii-tool eth0
eth0: no link

Tested on my Beagle XM.

v2: added mantainer to the list of recipient

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 drivers/net/usb/smsc95xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stephane Fillod - April 23, 2012, 7:43 p.m.
lun, Apr 23, 2012, Paolo Pisati skribis:
> Without this patch sysfs reports the cable as present
> 
> flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
> 1
> 
> while it's not:
> 
> flag@flag-desktop:~$ sudo mii-tool eth0
> eth0: no link
> 
> Tested on my Beagle XM.
> 
> v2: added mantainer to the list of recipient

His e-mail address has changed, but somehow it has not been updated yet
in MAINTAINERS directory:  steve.glendinning () shawell.net

> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  drivers/net/usb/smsc95xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 3444514..93d3252 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -1192,7 +1192,7 @@ static const struct driver_info smsc95xx_info = {
>  	.rx_fixup	= smsc95xx_rx_fixup,
>  	.tx_fixup	= smsc95xx_tx_fixup,
>  	.status		= smsc95xx_status,
> -	.flags		= FLAG_ETHER | FLAG_SEND_ZLP,
> +	.flags		= FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
>  };
>  
>  static const struct usb_device_id products[] = {

Tested this fix successfuly on elder brother smsc75xx, on top of
another patch yet-to-submit to fix smsc75xx's MDIO access.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 24, 2012, 4:42 a.m.
From: Stephane Fillod <fillods@users.sf.net>
Date: Mon, 23 Apr 2012 21:43:39 +0200

> lun, Apr 23, 2012, Paolo Pisati skribis:
>> Without this patch sysfs reports the cable as present
>> 
>> flag@flag-desktop:~$ cat /sys/class/net/eth0/carrier
>> 1
>> 
>> while it's not:
>> 
>> flag@flag-desktop:~$ sudo mii-tool eth0
>> eth0: no link
>> 
>> Tested on my Beagle XM.
>> 
>> v2: added mantainer to the list of recipient
> 
> His e-mail address has changed, but somehow it has not been updated yet
> in MAINTAINERS directory:  steve.glendinning () shawell.net

Steve, please send a maintainers etc. update and please provide
feedback on this link status fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve Glendinning - April 24, 2012, 3:45 p.m.
Hi all,

On 24 April 2012 05:42, David Miller <davem@davemloft.net> wrote:
>>> v2: added mantainer to the list of recipient
>>
>> His e-mail address has changed, but somehow it has not been updated yet
>> in MAINTAINERS directory:  steve.glendinning () shawell.net
>
> Steve, please send a maintainers etc. update and please provide
> feedback on this link status fix.

I submitted an update to MAINTAINERS last week, I don't think it's
been picked up yet.

Thanks for the patch Paulo, I'd like to test this out.  I'll get back
to you in a few days.
Steve Glendinning - April 26, 2012, 9:41 a.m.
Hi all,

On 24 April 2012 16:45, Steve Glendinning <steve@shawell.net> wrote:
> Hi all,
>
> On 24 April 2012 05:42, David Miller <davem@davemloft.net> wrote:
>>
>> Steve, please send a maintainers etc. update and please provide
>> feedback on this link status fix.

Good catch Paolo, this patch fixes reporting of link status when the
device is first connected with no ethernet cable plugged in.

I'll prepare the same patch for smsc75xx as it also suffers from the same issue.

Acked-by: Steve Glendinning <steve.glendinning@shawell.net>
David Miller - April 26, 2012, 9:56 a.m.
From: Steve Glendinning <steve@shawell.net>
Date: Thu, 26 Apr 2012 10:41:33 +0100

> Hi all,
> 
> On 24 April 2012 16:45, Steve Glendinning <steve@shawell.net> wrote:
>> Hi all,
>>
>> On 24 April 2012 05:42, David Miller <davem@davemloft.net> wrote:
>>>
>>> Steve, please send a maintainers etc. update and please provide
>>> feedback on this link status fix.
> 
> Good catch Paolo, this patch fixes reporting of link status when the
> device is first connected with no ethernet cable plugged in.
> 
> I'll prepare the same patch for smsc75xx as it also suffers from the same issue.
> 
> Acked-by: Steve Glendinning <steve.glendinning@shawell.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 3444514..93d3252 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -1192,7 +1192,7 @@  static const struct driver_info smsc95xx_info = {
 	.rx_fixup	= smsc95xx_rx_fixup,
 	.tx_fixup	= smsc95xx_tx_fixup,
 	.status		= smsc95xx_status,
-	.flags		= FLAG_ETHER | FLAG_SEND_ZLP,
+	.flags		= FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
 };
 
 static const struct usb_device_id products[] = {