From patchwork Sun Apr 22 17:50:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Pluzhnikov X-Patchwork-Id: 154298 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3AB2DB6FD3 for ; Mon, 23 Apr 2012 03:50:59 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1335721860; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:To:Subject:Message-Id:Date: From:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=n8RkqMZ 4BF8tEIiLTM29aVoPX1E=; b=EbiHMDi4yFzU7PKFCwc43NIeFHvmmnMca361vs4 k6W3AcYgRr4Cl6pOA2dGP6cVkqu9+pcNLRZJtwx0b+9pyyIv2AjXJqNoBnIiTzyh Aba4NaTlBW4olkr3bVwdHGIwp5mY9JSogj4ZzoGTNpfHFieL7uGHd0rJFYvG3GIf sGKY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:Received:Received:To:Subject:Message-Id:Date:From:X-Gm-Message-State:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=RdRXyW9YbN+EoCV4AWzDZbhwbsDZSMChlemg+7Ke9RRRt7EgZNFamcg2Ki+IW3 nsBMLNuSqSSK1T0bf1RZ1gdS6+/aulPbjCg9UM6s+GXNSPjaBQw7y6VIy75yVNOr De2wqgBQ0K+fxCB9NaovzbRKvWg1T/nas95OtAKOncwMg=; Received: (qmail 11987 invoked by alias); 22 Apr 2012 17:50:55 -0000 Received: (qmail 11974 invoked by uid 22791); 22 Apr 2012 17:50:54 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qc0-f201.google.com (HELO mail-qc0-f201.google.com) (209.85.216.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Apr 2012 17:50:41 +0000 Received: by qcse1 with SMTP id e1so1259998qcs.2 for ; Sun, 22 Apr 2012 10:50:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=to:subject:message-id:date:from:x-gm-message-state; bh=v0GVyYDbJAqPlR8nRpaHal9fzluNml9sNm9IEO5GJGU=; b=PiFE3ns1xCdugc6beHHOHovhorE1rgtFnSZq9lW2C2HiEc7aGuq+0WgQKPJBXlTNZW h087GkEmENoUkIV7xnp9MwdG6sFiyW2val61dwqj6gTXAcAUeZk/WcYJygDiDePv9eWb Hdl+OB0FqsjwIZmQsikklYo9jluOflKXjnMI5pES0DHZVPFbheyrGdSZikfFtPaGfOLS whivdj1a/JK8uzWwOJlQVFA6nmGkyx3X8S9cH4vo630qavXULynUIwsFYDegXGdcU4Cw OgVq2ikUT9fuhFBTyHZO7Q6oaepIjKFmNLaRdkB67Y5CYEng2W2f4LtkOi/VH/WfnFMr TIMw== Received: by 10.101.133.8 with SMTP id k8mr4913780ann.19.1335117040768; Sun, 22 Apr 2012 10:50:40 -0700 (PDT) Received: by 10.101.133.8 with SMTP id k8mr4913773ann.19.1335117040680; Sun, 22 Apr 2012 10:50:40 -0700 (PDT) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id y53si12290019yhe.4.2012.04.22.10.50.40 (version=TLSv1/SSLv3 cipher=AES128-SHA); Sun, 22 Apr 2012 10:50:40 -0700 (PDT) Received: from elbrus2.mtv.corp.google.com (elbrus2.mtv.corp.google.com [172.18.111.111]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id 9215B10004D; Sun, 22 Apr 2012 10:50:40 -0700 (PDT) Received: by elbrus2.mtv.corp.google.com (Postfix, from userid 74925) id 224BE190A4E; Sun, 22 Apr 2012 10:50:39 -0700 (PDT) To: reply@codereview.appspotmail.com,gcc-patches@gcc.gnu.org Subject: [patch][google/integration] Don't force tls-model to initial-exec when building libgomp (issue6107046) Message-Id: <20120422175040.224BE190A4E@elbrus2.mtv.corp.google.com> Date: Sun, 22 Apr 2012 10:50:39 -0700 (PDT) From: ppluzhnikov@google.com (Paul Pluzhnikov) X-Gm-Message-State: ALoCoQmgomGaU0JRT5nwX3aV4uRBUqL7cW4K6X3x8r1cY3NTDMMIE06sCMcOtW4vVmF6QP6AnpTvcF+ulqjCk4UYd5B+jraox6ztnteGn4GKNKrdsbMS5xHGiwKzMCoBf37FZvr1ote9B/4B/gCJKlkAbiuw6cHzMeYNpEo2HTSqW4Nzl3ci0x8= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Greetings, The patch below is needed for google/integration branch: we want to be able build libgomp.a with -fPIC, be able to link it into a shared library, and be able to dlopen that library without running out of static TLS space (-ftls-model=initial-exec precludes that last part). Google ref b/6368405 Google ref b/6156799 Tested: make && make check 2012-04-22 Paul Pluzhnikov * libgomp/configure.tgt: Don't force initial-exec. --- This patch is available for review at http://codereview.appspot.com/6107046 Index: libgomp/configure.tgt =================================================================== --- libgomp/configure.tgt (revision 186636) +++ libgomp/configure.tgt (working copy) @@ -10,16 +10,6 @@ # XCFLAGS Add extra compile flags to use. # XLDFLAGS Add extra link flags to use. -# Optimize TLS usage by avoiding the overhead of dynamic allocation. -if test $gcc_cv_have_tls = yes ; then - case "${target}" in - - *-*-linux*) - XCFLAGS="${XCFLAGS} -ftls-model=initial-exec" - ;; - esac -fi - # Since we require POSIX threads, assume a POSIX system by default. config_path="posix"