Patchwork [U-Boot] image/fit: drop inline markings on parser code

login
register
mail settings
Submitter Mike Frysinger
Date April 22, 2012, 4:59 p.m.
Message ID <1335113946-21136-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/154294/
State Accepted
Commit 314f634b488ff6345d20a0ed05f95a990021adb8
Headers show

Comments

Mike Frysinger - April 22, 2012, 4:59 p.m.
Putting "inline" on extern funcs makes no sense, so drop them.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 common/image.c  |    4 ++--
 include/image.h |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Wolfgang Denk - April 30, 2012, 2:39 p.m.
Dear Mike Frysinger,

In message <1335113946-21136-1-git-send-email-vapier@gentoo.org> you wrote:
> Putting "inline" on extern funcs makes no sense, so drop them.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  common/image.c  |    4 ++--
>  include/image.h |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/image.c b/common/image.c
index 342b315..91954ac 100644
--- a/common/image.c
+++ b/common/image.c
@@ -1829,7 +1829,7 @@  static int fit_parse_spec(const char *spec, char sepc, ulong addr_curr,
  *     addr and conf_name are set accordingly
  *     0 otherwise
  */
-inline int fit_parse_conf(const char *spec, ulong addr_curr,
+int fit_parse_conf(const char *spec, ulong addr_curr,
 		ulong *addr, const char **conf_name)
 {
 	return fit_parse_spec(spec, '#', addr_curr, addr, conf_name);
@@ -1855,7 +1855,7 @@  inline int fit_parse_conf(const char *spec, ulong addr_curr,
  *     addr and image_name are set accordingly
  *     0 otherwise
  */
-inline int fit_parse_subimage(const char *spec, ulong addr_curr,
+int fit_parse_subimage(const char *spec, ulong addr_curr,
 		ulong *addr, const char **image_name)
 {
 	return fit_parse_spec(spec, ':', addr_curr, addr, image_name);
diff --git a/include/image.h b/include/image.h
index a1c6e4e..aa9daa2 100644
--- a/include/image.h
+++ b/include/image.h
@@ -531,9 +531,9 @@  static inline int image_check_target_arch(const image_header_t *hdr)
 #define FIT_MAX_HASH_LEN	20	/* max(crc32_len(4), sha1_len(20)) */
 
 /* cmdline argument format parsing */
-inline int fit_parse_conf(const char *spec, ulong addr_curr,
+int fit_parse_conf(const char *spec, ulong addr_curr,
 		ulong *addr, const char **conf_name);
-inline int fit_parse_subimage(const char *spec, ulong addr_curr,
+int fit_parse_subimage(const char *spec, ulong addr_curr,
 		ulong *addr, const char **image_name);
 
 void fit_print_contents(const void *fit);