Patchwork [EXT4] super.c: unused variable warning without CONFIG_QUOTA

login
register
mail settings
Submitter Eldad Zack
Date April 22, 2012, 3:50 p.m.
Message ID <1335109852-17829-1-git-send-email-eldad@fogrefinery.com>
Download mbox | patch
Permalink /patch/154293/
State Accepted
Headers show

Comments

Eldad Zack - April 22, 2012, 3:50 p.m.
sb info is only checked with quota support.

fs/ext4/super.c: In function ‘parse_options’:
fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]

Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
---
 fs/ext4/super.c |    2 ++
 1 file changed, 2 insertions(+)
Theodore Ts'o - April 24, 2012, 1:39 a.m.
On Sun, Apr 22, 2012 at 05:50:52PM +0200, Eldad Zack wrote:
> sb info is only checked with quota support.
> 
> fs/ext4/super.c: In function ‘parse_options’:
> fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]
> 
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 6da1935..e1fb1d5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1597,7 +1597,9 @@  static int parse_options(char *options, struct super_block *sb,
 			 unsigned int *journal_ioprio,
 			 int is_remount)
 {
+#ifdef CONFIG_QUOTA
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
+#endif
 	char *p;
 	substring_t args[MAX_OPT_ARGS];
 	int token;