From patchwork Sat Apr 21 04:50:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Cochran X-Patchwork-Id: 154198 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 29D6EB6FC8 for ; Sat, 21 Apr 2012 14:51:18 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752328Ab2DUEvO (ORCPT ); Sat, 21 Apr 2012 00:51:14 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:47181 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743Ab2DUEvM (ORCPT ); Sat, 21 Apr 2012 00:51:12 -0400 Received: by mail-we0-f174.google.com with SMTP id x9so6444599wej.19 for ; Fri, 20 Apr 2012 21:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references; bh=Cb1obGOj077RbRpLvRw6mQnLVrmBAhl6BSyVZgeButI=; b=D8W26X6frtjBy4qmk1uJdVjcTmZu2MMpLq4nkvAmnHutXcT921aMPT11pLERnXIKn1 kS3M/M5jdVFOGhLX2mbLqjjDttWwgC0eQukH7DliMMm0SUPX0Q8ELHXF81UmRuixLgJs QIu/gJRlE1U75k0lhk7xojL4H3aQFcAbVaRdYzZ0IYlw35U/4C4zS7jCcZje5N3VMnuS JwEDrhM2Pi7pR2jid0fALKi5Kw5biul1xOgifO0vJhOELVESn/EWX4B0qzy4sOMu4cas q40cx1CpwhPtl+k1DTcC1ieqO80O1tfeetybsuHDywrR3PpfbiPnRtM5iG4WhOf7FvMi OUsA== Received: by 10.180.85.70 with SMTP id f6mr3371946wiz.5.1334983872185; Fri, 20 Apr 2012 21:51:12 -0700 (PDT) Received: from localhost.localdomain (089144206131.atnat0015.highway.a1.net. [89.144.206.131]) by mx.google.com with ESMTPS id k6sm2512285wiy.7.2012.04.20.21.51.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Apr 2012 21:51:11 -0700 (PDT) From: Richard Cochran To: Cc: David Miller , Takahiro Shimizu Subject: [PATCH net-next 9/9] pch_gbe: remove suspicious comment Date: Sat, 21 Apr 2012 06:50:36 +0200 Message-Id: <7d83edf3ac63ef1fd290a985bb617dcf98b6926e.1334983472.git.richardcochran@gmail.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The time stamping code in this driver appears to have been copied from the ixp4xx_eth.c driver, including this timing comment. I had actually measured the time stamp delay on an IXP425, but I really doubt that this value also applies here. Signed-off-by: Richard Cochran --- .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index e9b785e..89c6bcf 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c @@ -210,7 +210,6 @@ pch_tx_timestamp(struct pch_gbe_adapter *adapter, struct sk_buff *skb) /* * This really stinks, but we have to poll for the Tx time stamp. - * Usually, the time stamp is ready after 4 to 6 microseconds. */ for (cnt = 0; cnt < 100; cnt++) { val = pch_ch_event_read(pdev);