From patchwork Fri Apr 20 20:56:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 154144 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 12396B6FBC for ; Sat, 21 Apr 2012 06:57:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892Ab2DTU5V (ORCPT ); Fri, 20 Apr 2012 16:57:21 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:34059 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753607Ab2DTU4a (ORCPT ); Fri, 20 Apr 2012 16:56:30 -0400 Received: by mail-pb0-f46.google.com with SMTP id un15so1475811pbc.19 for ; Fri, 20 Apr 2012 13:56:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=EhNme3QiIgmYhT7F6V3wJEpsQtEMnEPrrlubOtHsQxM=; b=oTLDb4A84ybgMP5D+rbbow8SQLur4CQIxRl/7y+H+fA5ApjlMuVuetIImrNuzMvDEc ELYCSrS0xf1tXZjT/1CTDhoaCw57dp82kTbdMgGpdlknnzVg6RfovjclLJT7PK4E8/1w sLhaWE44QfBuLGzeXH7zeYXC5Sqbp6o6RKqOZpFjpRYmK/C+7eqMjg4XKHbR3AHdPNIp 5m3OvJ0GL6NP849UOWusuaFuZGnOI30+KgynaNRS0sVIGD1fXeyNAfvYzI1dy4UCelhi Rmfao7jCymcm4Df/iq7K4aDV+i8wJWkHsgNCdn4p/+wPJLV6wtmlZr2cbQacq9cOkVRj ws2Q== Received: by 10.68.226.5 with SMTP id ro5mr11255085pbc.74.1334955390360; Fri, 20 Apr 2012 13:56:30 -0700 (PDT) Received: from localhost.localdomain (S0106002369de4dac.cg.shawcable.net. [70.73.24.112]) by mx.google.com with ESMTPS id pg1sm6317632pbc.21.2012.04.20.13.56.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Apr 2012 13:56:29 -0700 (PDT) From: mathieu.poirier@linaro.org To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, mathieu.poirier@linaro.org Subject: [PATCH 6/8] donauboe: replace excessive udelay with msleep Date: Fri, 20 Apr 2012 14:56:14 -0600 Message-Id: <1334955376-17793-7-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1334955376-17793-1-git-send-email-mathieu.poirier@linaro.org> References: <1334955376-17793-1-git-send-email-mathieu.poirier@linaro.org> X-Gm-Message-State: ALoCoQlaX3nKA2Q+OgUpHfIC0HUm+ICTcDZGRNvewFb95I90kvCTmBeAICMLZV4WihfRAIhTX3u/ Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann No driver should spin the CPU for 10ms, so better use an msleep, which is allowed in the ->suspend function. Signed-off-by: Arnd Bergmann Signed-off-by: Mathieu Poirier --- drivers/net/irda/donauboe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c index 4351296..510b9c8 100644 --- a/drivers/net/irda/donauboe.c +++ b/drivers/net/irda/donauboe.c @@ -1710,7 +1710,7 @@ toshoboe_gotosleep (struct pci_dev *pci_dev, pm_message_t crap) /* Flush all packets */ while ((i--) && (self->txpending)) - udelay (10000); + msleep(10); spin_lock_irqsave(&self->spinlock, flags);