From patchwork Fri Apr 20 12:52:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 154036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 55A4FB704F for ; Fri, 20 Apr 2012 22:53:36 +1000 (EST) Received: from localhost ([::1]:48365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLDLA-0004Gy-It for incoming@patchwork.ozlabs.org; Fri, 20 Apr 2012 08:53:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLDKX-0002l9-VU for qemu-devel@nongnu.org; Fri, 20 Apr 2012 08:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SLDKR-00056s-Jl for qemu-devel@nongnu.org; Fri, 20 Apr 2012 08:52:53 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:36979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLDKR-00051E-BW for qemu-devel@nongnu.org; Fri, 20 Apr 2012 08:52:47 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Apr 2012 13:52:43 +0100 Received: from d06nrmr1407.portsmouth.uk.ibm.com (9.149.38.185) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 20 Apr 2012 13:52:41 +0100 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3KCqeBE2277552 for ; Fri, 20 Apr 2012 13:52:40 +0100 Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q3KCqeCT007859 for ; Fri, 20 Apr 2012 06:52:40 -0600 Received: from localhost (dyn-9-174-218-67.manchester-maybrook.uk.ibm.com [9.174.218.67]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q3KCqe5H007849; Fri, 20 Apr 2012 06:52:40 -0600 From: Stefan Hajnoczi To: Anthony Liguori Date: Fri, 20 Apr 2012 13:52:32 +0100 Message-Id: <1334926356-7807-4-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1334926356-7807-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1334926356-7807-1-git-send-email-stefanha@linux.vnet.ibm.com> x-cbid: 12042012-4966-0000-0000-000002168455 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.75.94.106 Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 3/7] qxl: Add missing GCC_FMT_ATTR and fix format specifier X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Weil val is an uint64_t, therefore %d was not correct. Signed-off-by: Stefan Weil Acked-by: Gerd Hoffmann Signed-off-by: Stefan Hajnoczi --- hw/qxl.c | 2 +- hw/qxl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index db2318e..c3540c3 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1370,7 +1370,7 @@ async_common: case QXL_IO_DESTROY_SURFACE_WAIT: if (val >= NUM_SURFACES) { qxl_guest_bug(d, "QXL_IO_DESTROY_SURFACE (async=%d):" - "%d >= NUM_SURFACES", async, val); + "%" PRIu64 " >= NUM_SURFACES", async, val); goto cancel_async; } qxl_spice_destroy_surface_wait(d, val, async); diff --git a/hw/qxl.h b/hw/qxl.h index 11a0db3..cbb1e2d 100644 --- a/hw/qxl.h +++ b/hw/qxl.h @@ -127,7 +127,7 @@ typedef struct PCIQXLDevice { /* qxl.c */ void *qxl_phys2virt(PCIQXLDevice *qxl, QXLPHYSICAL phys, int group_id); -void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg, ...); +void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg, ...) GCC_FMT_ATTR(2, 3); void qxl_spice_update_area(PCIQXLDevice *qxl, uint32_t surface_id, struct QXLRect *area, struct QXLRect *dirty_rects,