Patchwork [FWTS-TEST] checksum-0001: update checksums because of table loading fixes

login
register
mail settings
Submitter Colin King
Date April 20, 2012, 10:17 a.m.
Message ID <1334917046-2900-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/154002/
State Rejected
Headers show

Comments

Colin King - April 20, 2012, 10:17 a.m.
From: Colin Ian King <colin.king@canonical.com>

Due to the way we need to fixup (or create) some ACPI tables when mmap'ing them into
low 32 bit memory for the ACPICA core we also had to re-calculate the table checksums
which makes the checksum tests now fail.  Update the tests accordingly.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 checksum-0001/checksum-0001.log |    6 +++---
 checksum-0001/checksum-0003.log |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
Colin King - April 20, 2012, 10:24 a.m.
On 20/04/12 11:17, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Due to the way we need to fixup (or create) some ACPI tables when mmap'ing them into
> low 32 bit memory for the ACPICA core we also had to re-calculate the table checksums
> which makes the checksum tests now fail.  Update the tests accordingly.
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   checksum-0001/checksum-0001.log |    6 +++---
>   checksum-0001/checksum-0003.log |    6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/checksum-0001/checksum-0001.log b/checksum-0001/checksum-0001.log
> index 2f500f8..47dc271 100644
> --- a/checksum-0001/checksum-0001.log
> +++ b/checksum-0001/checksum-0001.log
> @@ -17,10 +17,10 @@ checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
>   checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
>   checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
>   checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum        PASSED: Test 1, Table RSDP has correct checksum 0xc5.
> +checksum        PASSED: Test 1, Table RSDT has correct checksum 0xd.
> +checksum        PASSED: Test 1, Table RSDP has correct checksum 0xb1.
>   checksum        PASSED: Test 1, Table RSDP has correct extended checksum
> -checksum        0x39.
> -checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
> +checksum        0xe.
>   checksum
>   checksum        =========================================================
>   checksum        19 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
> diff --git a/checksum-0001/checksum-0003.log b/checksum-0001/checksum-0003.log
> index 3ef8877..311cbb2 100644
> --- a/checksum-0001/checksum-0003.log
> +++ b/checksum-0001/checksum-0003.log
> @@ -24,10 +24,10 @@ checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
>   checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
>   checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
>   checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum        PASSED: Test 1, Table RSDP has correct checksum 0xc5.
> +checksum        PASSED: Test 1, Table RSDT has correct checksum 0xd.
> +checksum        PASSED: Test 1, Table RSDP has correct checksum 0xbc.
>   checksum        PASSED: Test 1, Table RSDP has correct extended checksum
> -checksum        0x39.
> -checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
> +checksum        0xb7.
>   checksum
>   checksum        =========================================================
>   checksum        18 passed, 1 failed, 0 warnings, 0 aborted, 0 skipped, 0

Nope, that's wrong, NACK

Colin

Patch

diff --git a/checksum-0001/checksum-0001.log b/checksum-0001/checksum-0001.log
index 2f500f8..47dc271 100644
--- a/checksum-0001/checksum-0001.log
+++ b/checksum-0001/checksum-0001.log
@@ -17,10 +17,10 @@  checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
 checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
 checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
 checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
-checksum        PASSED: Test 1, Table RSDP has correct checksum 0xc5.
+checksum        PASSED: Test 1, Table RSDT has correct checksum 0xd.
+checksum        PASSED: Test 1, Table RSDP has correct checksum 0xb1.
 checksum        PASSED: Test 1, Table RSDP has correct extended checksum
-checksum        0x39.
-checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
+checksum        0xe.
 checksum        
 checksum        =========================================================
 checksum        19 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
diff --git a/checksum-0001/checksum-0003.log b/checksum-0001/checksum-0003.log
index 3ef8877..311cbb2 100644
--- a/checksum-0001/checksum-0003.log
+++ b/checksum-0001/checksum-0003.log
@@ -24,10 +24,10 @@  checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
 checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
 checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
 checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
-checksum        PASSED: Test 1, Table RSDP has correct checksum 0xc5.
+checksum        PASSED: Test 1, Table RSDT has correct checksum 0xd.
+checksum        PASSED: Test 1, Table RSDP has correct checksum 0xbc.
 checksum        PASSED: Test 1, Table RSDP has correct extended checksum
-checksum        0x39.
-checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
+checksum        0xb7.
 checksum        
 checksum        =========================================================
 checksum        18 passed, 1 failed, 0 warnings, 0 aborted, 0 skipped, 0