Patchwork [FWTS-TEST] syntaxcheck-0001: new ACPICA core handles MIF/MAF flags w/o an error now, so fix test

login
register
mail settings
Submitter Colin King
Date April 20, 2012, 10:03 a.m.
Message ID <1334916191-32619-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/153996/
State Accepted
Headers show

Comments

Colin King - April 20, 2012, 10:03 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 syntaxcheck-0001/syntaxcheck-0001.log |   51 ++-------------------------------
 1 file changed, 3 insertions(+), 48 deletions(-)
Alex Hung - April 21, 2012, 10:26 a.m.
On 04/20/2012 06:03 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   syntaxcheck-0001/syntaxcheck-0001.log |   51 ++-------------------------------
>   1 file changed, 3 insertions(+), 48 deletions(-)
>
> diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log
> index f19e127..6d7af0e 100644
> --- a/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -1,53 +1,8 @@
>   syntaxcheck     Re-assemble DSDT and find syntax errors and warnings.
>   syntaxcheck     ---------------------------------------------------------
>   syntaxcheck     Test 1 of 2: Disassemble and reassemble DSDT
> -syntaxcheck     FAILED [HIGH] AMLAssemblerError4122: Test 1, Assembler
> -syntaxcheck     error in line 1070
> -syntaxcheck     Line | AML source
> -syntaxcheck     ---------------------------------------------------------
> -syntaxcheck     01067|                     0x00000000,         // Range Minimum
> -syntaxcheck     01068|                     0xDFFFFFFF,         // Range Maximum
> -syntaxcheck     01069|                     0x00000000,         // Translation Offset
> -syntaxcheck     01070|                     0x00000000,         // Length
> -syntaxcheck          |                              ^
> -syntaxcheck          | error 4122: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01071|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
> -syntaxcheck     01072|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> -syntaxcheck     01073|                     0x00000000,         // Granularity
> -syntaxcheck     =========================================================
> -syntaxcheck
> -syntaxcheck     ADVICE: (for error #4122): This occurs if the length is
> -syntaxcheck     zero and just one of the resource MIF/MAF flags are set,
> -syntaxcheck     or the length is non-zero and resource MIF/MAF flags are
> -syntaxcheck     both set. These are illegal combinations and need to be
> -syntaxcheck     fixed. See section 6.4.3.5 Address Space Resource
> -syntaxcheck     Descriptors of version 4.0a of the ACPI specification for
> -syntaxcheck     more details.
> -syntaxcheck
> -syntaxcheck     FAILED [HIGH] AMLAssemblerError4122: Test 1, Assembler
> -syntaxcheck     error in line 1084
> -syntaxcheck     Line | AML source
> -syntaxcheck     ---------------------------------------------------------
> -syntaxcheck     01081|                     0xFED40000,         // Range Minimum
> -syntaxcheck     01082|                     0xFED44FFF,         // Range Maximum
> -syntaxcheck     01083|                     0x00000000,         // Translation Offset
> -syntaxcheck     01084|                     0x00000000,         // Length
> -syntaxcheck          |                              ^
> -syntaxcheck          | error 4122: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01085|                     ,, , AddressRangeMemory, TypeStatic)
> -syntaxcheck     01086|             })
> -syntaxcheck     01087|             Method (_CRS, 0, Serialized)
> -syntaxcheck     =========================================================
> -syntaxcheck
> -syntaxcheck     ADVICE: (for error #4122): This occurs if the length is
> -syntaxcheck     zero and just one of the resource MIF/MAF flags are set,
> -syntaxcheck     or the length is non-zero and resource MIF/MAF flags are
> -syntaxcheck     both set. These are illegal combinations and need to be
> -syntaxcheck     fixed. See section 6.4.3.5 Address Space Resource
> -syntaxcheck     Descriptors of version 4.0a of the ACPI specification for
> -syntaxcheck     more details.
> -syntaxcheck
> -syntaxcheck     Table DSDT (0) reassembly: Found 2 errors, 0 warnings.
> +syntaxcheck     PASSED: Test 1, DSDT (0) reassembly, Found 0 errors, 0
> +syntaxcheck     warnings.
>   syntaxcheck
>   syntaxcheck     Test 2 of 2: Disassemble and reassemble SSDT
>   syntaxcheck     PASSED: Test 2, SSDT (0) reassembly, Found 0 errors, 0
> @@ -62,6 +17,6 @@ syntaxcheck     PASSED: Test 2, SSDT (4) reassembly, Found 0 errors, 0
>   syntaxcheck     warnings.
>   syntaxcheck
>   syntaxcheck     =========================================================
> -syntaxcheck     5 passed, 2 failed, 0 warnings, 0 aborted, 0 skipped, 0
> +syntaxcheck     6 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
>   syntaxcheck     info only.
>   syntaxcheck     =========================================================

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - April 23, 2012, 4:24 a.m.
On Fri, Apr 20, 2012 at 6:03 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  syntaxcheck-0001/syntaxcheck-0001.log |   51 ++-------------------------------
>  1 file changed, 3 insertions(+), 48 deletions(-)
>
> diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log
> index f19e127..6d7af0e 100644
> --- a/syntaxcheck-0001/syntaxcheck-0001.log
> +++ b/syntaxcheck-0001/syntaxcheck-0001.log
> @@ -1,53 +1,8 @@
>  syntaxcheck     Re-assemble DSDT and find syntax errors and warnings.
>  syntaxcheck     ---------------------------------------------------------
>  syntaxcheck     Test 1 of 2: Disassemble and reassemble DSDT
> -syntaxcheck     FAILED [HIGH] AMLAssemblerError4122: Test 1, Assembler
> -syntaxcheck     error in line 1070
> -syntaxcheck     Line | AML source
> -syntaxcheck     ---------------------------------------------------------
> -syntaxcheck     01067|                     0x00000000,         // Range Minimum
> -syntaxcheck     01068|                     0xDFFFFFFF,         // Range Maximum
> -syntaxcheck     01069|                     0x00000000,         // Translation Offset
> -syntaxcheck     01070|                     0x00000000,         // Length
> -syntaxcheck          |                              ^
> -syntaxcheck          | error 4122: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01071|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
> -syntaxcheck     01072|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
> -syntaxcheck     01073|                     0x00000000,         // Granularity
> -syntaxcheck     =========================================================
> -syntaxcheck
> -syntaxcheck     ADVICE: (for error #4122): This occurs if the length is
> -syntaxcheck     zero and just one of the resource MIF/MAF flags are set,
> -syntaxcheck     or the length is non-zero and resource MIF/MAF flags are
> -syntaxcheck     both set. These are illegal combinations and need to be
> -syntaxcheck     fixed. See section 6.4.3.5 Address Space Resource
> -syntaxcheck     Descriptors of version 4.0a of the ACPI specification for
> -syntaxcheck     more details.
> -syntaxcheck
> -syntaxcheck     FAILED [HIGH] AMLAssemblerError4122: Test 1, Assembler
> -syntaxcheck     error in line 1084
> -syntaxcheck     Line | AML source
> -syntaxcheck     ---------------------------------------------------------
> -syntaxcheck     01081|                     0xFED40000,         // Range Minimum
> -syntaxcheck     01082|                     0xFED44FFF,         // Range Maximum
> -syntaxcheck     01083|                     0x00000000,         // Translation Offset
> -syntaxcheck     01084|                     0x00000000,         // Length
> -syntaxcheck          |                              ^
> -syntaxcheck          | error 4122: Invalid combination of Length and Min/Max fixed flags
> -syntaxcheck     01085|                     ,, , AddressRangeMemory, TypeStatic)
> -syntaxcheck     01086|             })
> -syntaxcheck     01087|             Method (_CRS, 0, Serialized)
> -syntaxcheck     =========================================================
> -syntaxcheck
> -syntaxcheck     ADVICE: (for error #4122): This occurs if the length is
> -syntaxcheck     zero and just one of the resource MIF/MAF flags are set,
> -syntaxcheck     or the length is non-zero and resource MIF/MAF flags are
> -syntaxcheck     both set. These are illegal combinations and need to be
> -syntaxcheck     fixed. See section 6.4.3.5 Address Space Resource
> -syntaxcheck     Descriptors of version 4.0a of the ACPI specification for
> -syntaxcheck     more details.
> -syntaxcheck
> -syntaxcheck     Table DSDT (0) reassembly: Found 2 errors, 0 warnings.
> +syntaxcheck     PASSED: Test 1, DSDT (0) reassembly, Found 0 errors, 0
> +syntaxcheck     warnings.
>  syntaxcheck
>  syntaxcheck     Test 2 of 2: Disassemble and reassemble SSDT
>  syntaxcheck     PASSED: Test 2, SSDT (0) reassembly, Found 0 errors, 0
> @@ -62,6 +17,6 @@ syntaxcheck     PASSED: Test 2, SSDT (4) reassembly, Found 0 errors, 0
>  syntaxcheck     warnings.
>  syntaxcheck
>  syntaxcheck     =========================================================
> -syntaxcheck     5 passed, 2 failed, 0 warnings, 0 aborted, 0 skipped, 0
> +syntaxcheck     6 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
>  syntaxcheck     info only.
>  syntaxcheck     =========================================================
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log
index f19e127..6d7af0e 100644
--- a/syntaxcheck-0001/syntaxcheck-0001.log
+++ b/syntaxcheck-0001/syntaxcheck-0001.log
@@ -1,53 +1,8 @@ 
 syntaxcheck     Re-assemble DSDT and find syntax errors and warnings.
 syntaxcheck     ---------------------------------------------------------
 syntaxcheck     Test 1 of 2: Disassemble and reassemble DSDT
-syntaxcheck     FAILED [HIGH] AMLAssemblerError4122: Test 1, Assembler
-syntaxcheck     error in line 1070
-syntaxcheck     Line | AML source
-syntaxcheck     ---------------------------------------------------------
-syntaxcheck     01067|                     0x00000000,         // Range Minimum
-syntaxcheck     01068|                     0xDFFFFFFF,         // Range Maximum
-syntaxcheck     01069|                     0x00000000,         // Translation Offset
-syntaxcheck     01070|                     0x00000000,         // Length
-syntaxcheck          |                              ^
-syntaxcheck          | error 4122: Invalid combination of Length and Min/Max fixed flags
-syntaxcheck     01071|                     ,, _Y0D, AddressRangeMemory, TypeStatic)
-syntaxcheck     01072|                 DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
-syntaxcheck     01073|                     0x00000000,         // Granularity
-syntaxcheck     =========================================================
-syntaxcheck     
-syntaxcheck     ADVICE: (for error #4122): This occurs if the length is
-syntaxcheck     zero and just one of the resource MIF/MAF flags are set,
-syntaxcheck     or the length is non-zero and resource MIF/MAF flags are
-syntaxcheck     both set. These are illegal combinations and need to be
-syntaxcheck     fixed. See section 6.4.3.5 Address Space Resource
-syntaxcheck     Descriptors of version 4.0a of the ACPI specification for
-syntaxcheck     more details.
-syntaxcheck     
-syntaxcheck     FAILED [HIGH] AMLAssemblerError4122: Test 1, Assembler
-syntaxcheck     error in line 1084
-syntaxcheck     Line | AML source
-syntaxcheck     ---------------------------------------------------------
-syntaxcheck     01081|                     0xFED40000,         // Range Minimum
-syntaxcheck     01082|                     0xFED44FFF,         // Range Maximum
-syntaxcheck     01083|                     0x00000000,         // Translation Offset
-syntaxcheck     01084|                     0x00000000,         // Length
-syntaxcheck          |                              ^
-syntaxcheck          | error 4122: Invalid combination of Length and Min/Max fixed flags
-syntaxcheck     01085|                     ,, , AddressRangeMemory, TypeStatic)
-syntaxcheck     01086|             })
-syntaxcheck     01087|             Method (_CRS, 0, Serialized)
-syntaxcheck     =========================================================
-syntaxcheck     
-syntaxcheck     ADVICE: (for error #4122): This occurs if the length is
-syntaxcheck     zero and just one of the resource MIF/MAF flags are set,
-syntaxcheck     or the length is non-zero and resource MIF/MAF flags are
-syntaxcheck     both set. These are illegal combinations and need to be
-syntaxcheck     fixed. See section 6.4.3.5 Address Space Resource
-syntaxcheck     Descriptors of version 4.0a of the ACPI specification for
-syntaxcheck     more details.
-syntaxcheck     
-syntaxcheck     Table DSDT (0) reassembly: Found 2 errors, 0 warnings.
+syntaxcheck     PASSED: Test 1, DSDT (0) reassembly, Found 0 errors, 0
+syntaxcheck     warnings.
 syntaxcheck     
 syntaxcheck     Test 2 of 2: Disassemble and reassemble SSDT
 syntaxcheck     PASSED: Test 2, SSDT (0) reassembly, Found 0 errors, 0
@@ -62,6 +17,6 @@  syntaxcheck     PASSED: Test 2, SSDT (4) reassembly, Found 0 errors, 0
 syntaxcheck     warnings.
 syntaxcheck     
 syntaxcheck     =========================================================
-syntaxcheck     5 passed, 2 failed, 0 warnings, 0 aborted, 0 skipped, 0
+syntaxcheck     6 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0
 syntaxcheck     info only.
 syntaxcheck     =========================================================