Patchwork [2/9] ARM: sh-mobile: mackerel: Add error IRQ resource

login
register
mail settings
Submitter Bastian Hecht
Date April 20, 2012, 9:13 a.m.
Message ID <1334913230-23615-3-git-send-email-hechtb@gmail.com>
Download mbox | patch
Permalink /patch/153980/
State Not Applicable
Headers show

Comments

Bastian Hecht - April 20, 2012, 9:13 a.m.
Supply the platform data for the FLSTEI error IRQ.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Laurent Pinchart - April 21, 2012, 2:30 p.m.
Hi Bastian,

Thanks for the patch.

On Friday 20 April 2012 11:13:43 Bastian Hecht wrote:
> Supply the platform data for the FLSTEI error IRQ.

This should come before your 1/9 patch, otherwise the FLCTL driver will fail 
to get the IRQ, breaking git bisect.

> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c
> b/arch/arm/mach-shmobile/board-mackerel.c index 8758f94..1de1fb7 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -990,7 +990,11 @@ static struct resource nand_flash_resources[] = {
>  		.start	= 0xe6a30000,
>  		.end	= 0xe6a3009b,
>  		.flags	= IORESOURCE_MEM,
> -	}
> +	},
> +	[1] = {
> +		.start	= evt2irq(0x0d80), /* flstei: status error irq */
> +		.flags	= IORESOURCE_IRQ,
> +	},
>  };
> 
>  static struct sh_flctl_platform_data nand_flash_data = {
Bastian Hecht - April 23, 2012, 8:43 a.m.
Hello Laurent,

2012/4/21 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> Hi Bastian,
>
> Thanks for the patch.
>
> On Friday 20 April 2012 11:13:43 Bastian Hecht wrote:
>> Supply the platform data for the FLSTEI error IRQ.
>
> This should come before your 1/9 patch, otherwise the FLCTL driver will fail
> to get the IRQ, breaking git bisect.

"git bisect" - I should try this :D

Thanks, I'll swap it.

Best regards,

 Bastian Hecht

>> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
>> ---
>>  arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-shmobile/board-mackerel.c
>> b/arch/arm/mach-shmobile/board-mackerel.c index 8758f94..1de1fb7 100644
>> --- a/arch/arm/mach-shmobile/board-mackerel.c
>> +++ b/arch/arm/mach-shmobile/board-mackerel.c
>> @@ -990,7 +990,11 @@ static struct resource nand_flash_resources[] = {
>>               .start  = 0xe6a30000,
>>               .end    = 0xe6a3009b,
>>               .flags  = IORESOURCE_MEM,
>> -     }
>> +     },
>> +     [1] = {
>> +             .start  = evt2irq(0x0d80), /* flstei: status error irq */
>> +             .flags  = IORESOURCE_IRQ,
>> +     },
>>  };
>>
>>  static struct sh_flctl_platform_data nand_flash_data = {
> --
> Regards,
>
> Laurent Pinchart
>

Patch

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 8758f94..1de1fb7 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -990,7 +990,11 @@  static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {