From patchwork Fri Apr 20 01:38:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: libata: clear error mask of old error history Date: Thu, 19 Apr 2012 15:38:58 -0000 From: Lin Ming X-Patchwork-Id: 153903 Message-Id: <1334885938.4927.11.camel@minggr> To: Jeff Garzik Cc: linux-ide@vger.kernel.org, Martin Mokrejs The old error history was cleared in ata_ering_clear(). It only sets ATA_EFLAG_OLD_ER eflags, but the err_mask was not cleared. So ata_ering_map() still iterates the old error history. This causes problem, for example, wrong probe trials count were returned in ata_eh_schedule_probe(), which in turn causes SATA link speed to be slowed down to 1.5Gbps. Reported-and-tested-by: Martin Mokrejs Signed-off-by: Lin Ming --- Hi Jeff, This patch fixes an old regression introduced in 2.6.37-rc1 of commit d902747. So it should be included into stable releases since 2.6.37. drivers/ata/libata-eh.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index c61316e..4c6f49b 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -419,9 +419,10 @@ int ata_ering_map(struct ata_ering *ering, return rc; } -int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg) +static int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg) { ent->eflags |= ATA_EFLAG_OLD_ER; + ent->err_mask = 0; return 0; }