Patchwork ks8851: Fix request_irq/free_irq mismatch

login
register
mail settings
Submitter mjr@cs.wisc.edu
Date April 19, 2012, 5:17 p.m.
Message ID <1334855837-28366-1-git-send-email-mjr@cs.wisc.edu>
Download mbox | patch
Permalink /patch/153841/
State Accepted
Delegated to: David Miller
Headers show

Comments

mjr@cs.wisc.edu - April 19, 2012, 5:17 p.m.
From: Matt Renzelmann <mjr@cs.wisc.edu>

The dev_id parameter passed to free_irq needs to match the one passed
to the corresponding request_irq.

Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>
---

Resending -- forgot driver name in the title.  Sorry about that.

 drivers/net/ethernet/micrel/ks8851.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stephen Boyd - April 19, 2012, 6:13 p.m.
On 04/19/12 10:17, mjr@cs.wisc.edu wrote:
> From: Matt Renzelmann <mjr@cs.wisc.edu>
>
> The dev_id parameter passed to free_irq needs to match the one passed
> to the corresponding request_irq.
>
> Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>

Acked-by: Stephen Boyd <sboyd@codeaurora.org>
David Miller - April 21, 2012, 7:56 p.m.
From: Stephen Boyd <sboyd@codeaurora.org>
Date: Thu, 19 Apr 2012 11:13:51 -0700

> On 04/19/12 10:17, mjr@cs.wisc.edu wrote:
>> From: Matt Renzelmann <mjr@cs.wisc.edu>
>>
>> The dev_id parameter passed to free_irq needs to match the one passed
>> to the corresponding request_irq.
>>
>> Signed-off-by: Matt Renzelmann <mjr@cs.wisc.edu>
> 
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
index e5dc075..a8b7d5b 100644
--- a/drivers/net/ethernet/micrel/ks8851.c
+++ b/drivers/net/ethernet/micrel/ks8851.c
@@ -1524,7 +1524,7 @@  static int __devinit ks8851_probe(struct spi_device *spi)
 
 
 err_netdev:
-	free_irq(ndev->irq, ndev);
+	free_irq(ndev->irq, ks);
 
 err_id:
 err_irq: