| Message ID | 20120419162859.904574e2518c5a904802efbc@canb.auug.org.au |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 19 Apr 2012 16:28:59 +1000 > After merging the final tree, today's linux-next build (sparc64 defconfig) > failed like this: > > net/ipv4/route.c: In function 'ip_static_sysctl_init': > net/ipv4/route.c:3517:2: error: implicit declaration of function 'kmemleak_not_leak' [-Werror=implicit-function-declaration] ... > net/core/sysctl_net_core.c: In function 'sysctl_core_init': > net/core/sysctl_net_core.c:259:2: error: implicit declaration of function 'kmemleak_not_leak' [-Werror=implicit-function-declaration] ... I already checked in a fix for this, thanks Stephen. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index cee5991..247c69b 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -14,6 +14,7 @@ #include <linux/vmalloc.h> #include <linux/init.h> #include <linux/slab.h> +#include <linux/kmemleak.h> #include <net/ip.h> #include <net/sock.h> diff --git a/net/ipv4/route.c b/net/ipv4/route.c index bcd4744..dcb4205 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -93,6 +93,7 @@ #include <linux/times.h> #include <linux/slab.h> #include <linux/prefetch.h> +#include <linux/kmemleak.h> #include <net/dst.h> #include <net/net_namespace.h> #include <net/protocol.h>
Hi all, After merging the final tree, today's linux-next build (sparc64 defconfig) failed like this: net/ipv4/route.c: In function 'ip_static_sysctl_init': net/ipv4/route.c:3517:2: error: implicit declaration of function 'kmemleak_not_leak' [-Werror=implicit-function-declaration] Caused by commit 7f5938810890 ("net/ipv4:Remove two memleak reports by kmemleak_not_leak"). net/core/sysctl_net_core.c: In function 'sysctl_core_init': net/core/sysctl_net_core.c:259:2: error: implicit declaration of function 'kmemleak_not_leak' [-Werror=implicit-function-declaration] Caused by commit 798ec84d4575 ("net/core:Remove memleak reports by kmemleak_not_leak"). I added this patch for today: From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 19 Apr 2012 16:25:16 +1000 Subject: [PATCH] net: using kmemleak_not_leak requires including kmemleak.h fixes these build errors: net/ipv4/route.c: In function 'ip_static_sysctl_init': net/ipv4/route.c:3517:2: error: implicit declaration of function 'kmemleak_not_leak' [-Werror=implicit-function-declaration] net/core/sysctl_net_core.c: In function 'sysctl_core_init': net/core/sysctl_net_core.c:259:2: error: implicit declaration of function 'kmemleak_not_leak' [-Werror=implicit-function-declaration] Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- net/core/sysctl_net_core.c | 1 + net/ipv4/route.c | 1 + 2 files changed, 2 insertions(+)