Message ID | 20120418190521.GB2436@tuxdriver.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: "John W. Linville" <linville@tuxdriver.com> Date: Wed, 18 Apr 2012 15:05:22 -0400 > Another batch of wireless updates intended for 3.5... > > Highlights include some wl12xx refactoring, NFC HCI and SHDLC updates, > an ath6kl pull, some mesh updates, and the usual updates to iwlwifi, > ath9k, brcm80211, mwifiex, libertas, and other drivers. > > Please let me know if there are problems! Also pulled, thanks a lot. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18.04.2012 21:36, David Miller wrote: > From: "John W. Linville" <linville@tuxdriver.com> > Date: Wed, 18 Apr 2012 15:05:22 -0400 > >> Another batch of wireless updates intended for 3.5... >> >> Highlights include some wl12xx refactoring, NFC HCI and SHDLC updates, >> an ath6kl pull, some mesh updates, and the usual updates to iwlwifi, >> ath9k, brcm80211, mwifiex, libertas, and other drivers. >> >> Please let me know if there are problems! > > Also pulled, thanks a lot. Commit "iwlwifi: move scan related declarations out of iwl-core.h" http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=commitdiff;h=8fb96d6e176cbf0a97b2391fa1fa09e608ee86f8 breaks the compile when CONFIG_IWLWIFI_DEBUGFS is not set, see: CC [M] drivers/net/wireless/iwlwifi/iwl-agn-tt.o In file included from drivers/net/wireless/iwlwifi/iwl-agn-tt.c:40:0: drivers/net/wireless/iwlwifi/iwl-core.h:97:19: error: static declaration of 'iwl_alloc_traffic_mem' follows non-static declaration drivers/net/wireless/iwlwifi/iwl-agn.h:513:5: note: previous declaration of 'iwl_alloc_traffic_mem' was here make[4]: *** [drivers/net/wireless/iwlwifi/iwl-agn-tt.o] Error 1 make[3]: *** [drivers/net/wireless/iwlwifi] Error 2 make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 make: *** Waiting for unfinished jobs.... Please check these kind of source reorganizations with different CONFIG settings too. Regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hey Oliver, >Commit "iwlwifi: move scan related declarations out of iwl-core.h" > >http://git.kernel.org/?p=linux/kernel/git/davem/net- >next.git;a=commitdiff;h=8fb96d6e176cbf0a97b2391fa1fa09e608ee86f8 > >breaks the compile when CONFIG_IWLWIFI_DEBUGFS is not set, see: [MV] Sorry about breaking net-next. I took a look at the patch that you've pointed to, and actually it's a patch that caused the problem. The commit that broke it is actually: iwlwifi: expose static methods for MVM use http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=commit;h=50c1e9a9e3b086465b1467d448c10f7fa1e0eb5c It was fixed internally in a subsequent patch, but that patch has not made it into net-next. I don't see it in the public iwlwifi repository either. We'll add the fix to the repository so you can pick it up. Thanks & sorry, Meenakshi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Venkataraman, Meenakshi" <meenakshi.venkataraman@intel.com> Date: Thu, 19 Apr 2012 19:47:58 +0000 > It was fixed internally in a subsequent patch, but that patch has > not made it into net-next. I don't see it in the public iwlwifi > repository either. We'll add the fix to the repository so you can > pick it up. That's not how this works. You should submit a patch to fix the build directly to me, immediately, so that I can push it directly into net-next as fast as possible. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David, >> It was fixed internally in a subsequent patch, but that patch has not >> made it into net-next. I don't see it in the public iwlwifi repository >> either. We'll add the fix to the repository so you can pick it up. > >That's not how this works. > >You should submit a patch to fix the build directly to me, immediately, so that I >can push it directly into net-next as fast as possible. [MV] Okay -- this is good to know. Essentially -- if any upstream tree breaks due to our work, then a fix should be directly submitted ASAP to the maintainer of that tree. I see that Wey-Yi has already sent you the fix, so nothing left for me to do on this one. Thanks, Meenakshi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks guys! I just pulled net-next and it's compiling properly now. Regards, Oliver On 19.04.2012 23:07, Venkataraman, Meenakshi wrote: > Hi David, > >>> It was fixed internally in a subsequent patch, but that patch has not >>> made it into net-next. I don't see it in the public iwlwifi repository >>> either. We'll add the fix to the repository so you can pick it up. >> >> That's not how this works. >> >> You should submit a patch to fix the build directly to me, immediately, so that I >> can push it directly into net-next as fast as possible. > > [MV] Okay -- this is good to know. Essentially -- if any upstream tree breaks due to our work, then a fix should be directly submitted ASAP to the maintainer of that tree. > > I see that Wey-Yi has already sent you the fix, so nothing left for me to do on this one. > > Thanks, > Meenakshi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html