Patchwork [PULL,0/9] Tracing patches

login
register
mail settings
Submitter Stefan Hajnoczi
Date April 18, 2012, 2:07 p.m.
Message ID <1334758044-14443-1-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox
Permalink /patch/153521/
State New
Headers show

Pull-request

git://github.com/stefanha/qemu.git tracing

Comments

Stefan Hajnoczi - April 18, 2012, 2:07 p.m.
The last tracing pull for 1.1 before we merge only fixes.

The following changes since commit 6e7a7f3d9bc2031b4c93c05400b18775ba1b1f55:

  Allow controlling volume with PulseAudio backend (2012-04-17 16:57:58 +0400)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tracing

for you to fetch changes up to 256a721d46a112d8807a488ec0176985c09bbbf1:

  tracetool: handle DTrace keywords 'in', 'next', 'self' (2012-04-18 14:03:00 +0100)

----------------------------------------------------------------
Lluís Vilanova (8):
      tracetool: Rewrite infrastructure as python modules
      tracetool: Add module for the 'c' format
      tracetool: Add module for the 'h' format
      tracetool: Add support for the 'stderr' backend
      tracetool: Add support for the 'simple' backend
      tracetool: Add support for the 'ust' backend
      tracetool: Add support for the 'dtrace' backend
      tracetool: Add MAINTAINERS info

Stefan Hajnoczi (1):
      tracetool: handle DTrace keywords 'in', 'next', 'self'

 MAINTAINERS                           |    2 +
 Makefile.objs                         |    6 +-
 Makefile.target                       |   13 +-
 configure                             |    4 +-
 scripts/tracetool                     |  666 ---------------------------------
 scripts/tracetool.py                  |  138 +++++++
 scripts/tracetool/__init__.py         |  271 ++++++++++++++
 scripts/tracetool/backend/__init__.py |  111 ++++++
 scripts/tracetool/backend/dtrace.py   |   97 +++++
 scripts/tracetool/backend/simple.py   |   55 +++
 scripts/tracetool/backend/stderr.py   |   56 +++
 scripts/tracetool/backend/ust.py      |   90 +++++
 scripts/tracetool/format/__init__.py  |   99 +++++
 scripts/tracetool/format/c.py         |   20 +
 scripts/tracetool/format/d.py         |   20 +
 scripts/tracetool/format/h.py         |   45 +++
 scripts/tracetool/format/stap.py      |   20 +
 17 files changed, 1036 insertions(+), 677 deletions(-)
 delete mode 100755 scripts/tracetool
 create mode 100755 scripts/tracetool.py
 create mode 100644 scripts/tracetool/__init__.py
 create mode 100644 scripts/tracetool/backend/__init__.py
 create mode 100644 scripts/tracetool/backend/dtrace.py
 create mode 100644 scripts/tracetool/backend/simple.py
 create mode 100644 scripts/tracetool/backend/stderr.py
 create mode 100644 scripts/tracetool/backend/ust.py
 create mode 100644 scripts/tracetool/format/__init__.py
 create mode 100644 scripts/tracetool/format/c.py
 create mode 100644 scripts/tracetool/format/d.py
 create mode 100644 scripts/tracetool/format/h.py
 create mode 100644 scripts/tracetool/format/stap.py
Andreas Färber - April 24, 2012, 6 p.m.
Am 18.04.2012 16:07, schrieb Stefan Hajnoczi:
> The last tracing pull for 1.1 before we merge only fixes.
> 
> The following changes since commit 6e7a7f3d9bc2031b4c93c05400b18775ba1b1f55:
> 
>   Allow controlling volume with PulseAudio backend (2012-04-17 16:57:58 +0400)
> 
> are available in the git repository at:
> 
>   git://github.com/stefanha/qemu.git tracing
> 
> for you to fetch changes up to 256a721d46a112d8807a488ec0176985c09bbbf1:
> 
>   tracetool: handle DTrace keywords 'in', 'next', 'self' (2012-04-18 14:03:00 +0100)
> 
> ----------------------------------------------------------------
> Lluís Vilanova (8):
>       tracetool: Rewrite infrastructure as python modules
>       tracetool: Add module for the 'c' format
>       tracetool: Add module for the 'h' format
>       tracetool: Add support for the 'stderr' backend
>       tracetool: Add support for the 'simple' backend
>       tracetool: Add support for the 'ust' backend
>       tracetool: Add support for the 'dtrace' backend
>       tracetool: Add MAINTAINERS info
> 
> Stefan Hajnoczi (1):
>       tracetool: handle DTrace keywords 'in', 'next', 'self'

While the thought of not having to deal with oldish Sun shells was
certainly compelling, tracetool.py seems to require Python 2.6 and
breaks with Python 2.5.1 on Mac OS X v10.5 (the last version to support
ppc). Any chance you can fix this?

What I'm seeing when the command line options are correct is this:

Error: invalid trace backend
Please choose a supported trace backend.

And when not, I see the following amidst the usage information:

[...]
  --enable-trace-backend=B Set trace backend
  File "/Users/andreas/QEMU/qemu/scripts/tracetool.py", line 73
    except getopt.GetoptError as err:
                               ^
SyntaxError: invalid syntax
                           Available backends:
[...]

I.e. `python scripts/tracetool.py --list-backends` breaks.

Andreas
Stefan Hajnoczi - April 25, 2012, 9:43 a.m.
On Tue, Apr 24, 2012 at 7:00 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 18.04.2012 16:07, schrieb Stefan Hajnoczi:
>> The last tracing pull for 1.1 before we merge only fixes.
>>
>> The following changes since commit 6e7a7f3d9bc2031b4c93c05400b18775ba1b1f55:
>>
>>   Allow controlling volume with PulseAudio backend (2012-04-17 16:57:58 +0400)
>>
>> are available in the git repository at:
>>
>>   git://github.com/stefanha/qemu.git tracing
>>
>> for you to fetch changes up to 256a721d46a112d8807a488ec0176985c09bbbf1:
>>
>>   tracetool: handle DTrace keywords 'in', 'next', 'self' (2012-04-18 14:03:00 +0100)
>>
>> ----------------------------------------------------------------
>> Lluís Vilanova (8):
>>       tracetool: Rewrite infrastructure as python modules
>>       tracetool: Add module for the 'c' format
>>       tracetool: Add module for the 'h' format
>>       tracetool: Add support for the 'stderr' backend
>>       tracetool: Add support for the 'simple' backend
>>       tracetool: Add support for the 'ust' backend
>>       tracetool: Add support for the 'dtrace' backend
>>       tracetool: Add MAINTAINERS info
>>
>> Stefan Hajnoczi (1):
>>       tracetool: handle DTrace keywords 'in', 'next', 'self'
>
> While the thought of not having to deal with oldish Sun shells was
> certainly compelling, tracetool.py seems to require Python 2.6 and
> breaks with Python 2.5.1 on Mac OS X v10.5 (the last version to support
> ppc). Any chance you can fix this?
>
> What I'm seeing when the command line options are correct is this:
>
> Error: invalid trace backend
> Please choose a supported trace backend.

Thanks for reporting this.  I have sent a fix and tested that all
backends now work with Python 2.5.6.

Please let me know if this fixes the issue for you.

Stefan