Patchwork [U-Boot] arm: ea20: Change macro from BOARD_LATE_INIT to CONFIG_BOARD_LATE_INIT

login
register
mail settings
Submitter Nobuhiro Iwamatsu
Date April 18, 2012, 2:41 a.m.
Message ID <1334716914-8423-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
Download mbox | patch
Permalink /patch/153369/
State Accepted
Commit 2d594fd55d5d85f68b80cb7cc231157b9df231c7
Delegated to: Tom Rini
Headers show

Comments

Nobuhiro Iwamatsu - April 18, 2012, 2:41 a.m.
With almost all the architecture and board BOARD_LATE_INIT does not use.
CONFIG_BOARD_LATE_INIT is used instead.
This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
CC: Stefano Babic <sbabic@denx.de>
---
 board/davinci/ea20/ea20.c |    4 ++--
 include/configs/ea20.h    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Stefano Babic - April 18, 2012, 7:36 a.m.
On 18/04/2012 04:41, Nobuhiro Iwamatsu wrote:
> With almost all the architecture and board BOARD_LATE_INIT does not use.
> CONFIG_BOARD_LATE_INIT is used instead.
> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> CC: Stefano Babic <sbabic@denx.de>
> ---
>  board/davinci/ea20/ea20.c |    4 ++--
>  include/configs/ea20.h    |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/board/davinci/ea20/ea20.c b/board/davinci/ea20/ea20.c
> index 43632c2..7e00040 100644
> --- a/board/davinci/ea20/ea20.c
> +++ b/board/davinci/ea20/ea20.c
> @@ -272,7 +272,7 @@ int board_init(void)
>  	return 0;
>  }
>  
> -#ifdef BOARD_LATE_INIT
> +#ifdef CONFIG_BOARD_LATE_INIT
>  
>  int board_late_init(void)
>  {
> @@ -287,7 +287,7 @@ int board_late_init(void)
>  
>  	return 0;
>  }
> -#endif /* BOARD_LATE_INIT */
> +#endif /* CONFIG_BOARD_LATE_INIT */
>  
>  #ifdef CONFIG_DRIVER_TI_EMAC
>  
> diff --git a/include/configs/ea20.h b/include/configs/ea20.h
> index e059b30..2c44ddb 100644
> --- a/include/configs/ea20.h
> +++ b/include/configs/ea20.h
> @@ -31,7 +31,7 @@
>  #define	CONFIG_SYS_USE_NAND
>  #define CONFIG_DRIVER_TI_EMAC_USE_RMII
>  #define CONFIG_BOARD_EARLY_INIT_F
> -#define BOARD_LATE_INIT
> +#define CONFIG_BOARD_LATE_INIT
>  #define CONFIG_VIDEO
>  #define CONFIG_PREBOOT
>  

Acked-by: Stefano Babic <sbabic@denx.de>

Thanks,
Stefano Babic
Albert ARIBAUD - April 19, 2012, 6:44 a.m.
Hi Nobuhiro Iwamatsu,

Le 18/04/2012 04:41, Nobuhiro Iwamatsu a écrit :
> With almost all the architecture and board BOARD_LATE_INIT does not use.
> CONFIG_BOARD_LATE_INIT is used instead.
> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.

I think the commit message above is redundant with the commit summary, 
especially for a trivial one-line change. Can you just post a V2 patch 
with the same code change and commit summary, but without the commit 
message?

Amicalement,
Albert ARIBAUD - April 19, 2012, 6:48 a.m.
Le 19/04/2012 08:44, Albert ARIBAUD a écrit :
> Hi Nobuhiro Iwamatsu,
>
> Le 18/04/2012 04:41, Nobuhiro Iwamatsu a écrit :
>> With almost all the architecture and board BOARD_LATE_INIT does not use.
>> CONFIG_BOARD_LATE_INIT is used instead.
>> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.
>
> I think the commit message above is redundant with the commit summary,
> especially for a trivial one-line change. Can you just post a V2 patch
> with the same code change and commit summary, but without the commit
> message?

... actually, you could apply this to all your elementary patches re 
BOARD_LATE_INIT, and then submit them in a single patch set.

Amicalement,
Nobuhiro Iwamatsu - May 7, 2012, 1:38 a.m.
Hi,

Sorry, reply is late.

2012/4/19 Albert ARIBAUD <albert.u.boot@aribaud.net>:
> Le 19/04/2012 08:44, Albert ARIBAUD a écrit :
>
>> Hi Nobuhiro Iwamatsu,
>>
>> Le 18/04/2012 04:41, Nobuhiro Iwamatsu a écrit :
>>>
>>> With almost all the architecture and board BOARD_LATE_INIT does not use.
>>> CONFIG_BOARD_LATE_INIT is used instead.
>>> This changed CONFIG_BOARD_LATE_INIT from BOARD_LATE_INIT.
>>
>>
>> I think the commit message above is redundant with the commit summary,
>> especially for a trivial one-line change. Can you just post a V2 patch
>> with the same code change and commit summary, but without the commit
>> message?
>
>
> ... actually, you could apply this to all your elementary patches re
> BOARD_LATE_INIT, and then submit them in a single patch set.
>

I thought that I would resend to one patch collectively.
However, these were already taken into your repository.
Thank you.

Best regards,
  Nobuhiro

Patch

diff --git a/board/davinci/ea20/ea20.c b/board/davinci/ea20/ea20.c
index 43632c2..7e00040 100644
--- a/board/davinci/ea20/ea20.c
+++ b/board/davinci/ea20/ea20.c
@@ -272,7 +272,7 @@  int board_init(void)
 	return 0;
 }
 
-#ifdef BOARD_LATE_INIT
+#ifdef CONFIG_BOARD_LATE_INIT
 
 int board_late_init(void)
 {
@@ -287,7 +287,7 @@  int board_late_init(void)
 
 	return 0;
 }
-#endif /* BOARD_LATE_INIT */
+#endif /* CONFIG_BOARD_LATE_INIT */
 
 #ifdef CONFIG_DRIVER_TI_EMAC
 
diff --git a/include/configs/ea20.h b/include/configs/ea20.h
index e059b30..2c44ddb 100644
--- a/include/configs/ea20.h
+++ b/include/configs/ea20.h
@@ -31,7 +31,7 @@ 
 #define	CONFIG_SYS_USE_NAND
 #define CONFIG_DRIVER_TI_EMAC_USE_RMII
 #define CONFIG_BOARD_EARLY_INIT_F
-#define BOARD_LATE_INIT
+#define CONFIG_BOARD_LATE_INIT
 #define CONFIG_VIDEO
 #define CONFIG_PREBOOT