Patchwork [09/10] MXS: Enable USB on M28EVK

login
register
mail settings
Submitter Marek Vasut
Date April 18, 2012, 2:07 a.m.
Message ID <1334714869-19282-10-git-send-email-marex@denx.de>
Download mbox | patch
Permalink /patch/153360/
State New
Headers show

Comments

Marek Vasut - April 18, 2012, 2:07 a.m.
Enable the second USB port on M28EVK board.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Chen Peter-B29397 <B29397@freescale.com>
Cc: Detlev Zundel <dzu@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Li Frank-B20596 <B20596@freescale.com>
Cc: Lin Tony-B19295 <B19295@freescale.com>
Cc: Linux USB <linux-usb@vger.kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Subodh Nijsure <snijsure@grid-net.com>
Cc: Tony Lin <tony.lin@freescale.com>
Cc: Wolfgang Denk <wd@denx.de>
---
 arch/arm/mach-mxs/Kconfig       |    2 ++
 arch/arm/mach-mxs/mach-m28evk.c |    9 +++++++++
 2 files changed, 11 insertions(+)
Sergei Shtylyov - April 18, 2012, 12:08 p.m.
Hello.

On 18-04-2012 6:07, Marek Vasut wrote:

> Enable the second USB port on M28EVK board.

> Signed-off-by: Marek Vasut<marex@denx.de>
> Cc: Chen Peter-B29397<B29397@freescale.com>
> Cc: Detlev Zundel<dzu@denx.de>
> Cc: Fabio Estevam<festevam@gmail.com>
> Cc: Li Frank-B20596<B20596@freescale.com>
> Cc: Lin Tony-B19295<B19295@freescale.com>
> Cc: Linux USB<linux-usb@vger.kernel.org>
> Cc: Sascha Hauer<s.hauer@pengutronix.de>
> Cc: Shawn Guo<shawn.guo@freescale.com>
> Cc: Shawn Guo<shawn.guo@linaro.org>
> Cc: Stefano Babic<sbabic@denx.de>
> Cc: Subodh Nijsure<snijsure@grid-net.com>
> Cc: Tony Lin<tony.lin@freescale.com>
> Cc: Wolfgang Denk<wd@denx.de>
> ---
>   arch/arm/mach-mxs/Kconfig       |    2 ++
>   arch/arm/mach-mxs/mach-m28evk.c |    9 +++++++++
>   2 files changed, 11 insertions(+)

> diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
> index 9dbf29f..5b5566c 100644
> --- a/arch/arm/mach-mxs/Kconfig
> +++ b/arch/arm/mach-mxs/Kconfig
[...]
> @@ -377,6 +382,10 @@ static void __init m28evk_init(void)
>   	mx28_add_ts(&touch_pdata);
>
>   	mx28_add_gpmi_nand(&m28evk_gpmi_nand_data);
> +
> +	gpio_request_one(MXS_GPIO_NR(3, 13), GPIOF_OUT_INIT_LOW, "USB Power");

    Still can fail, and you don't handle it (unlike the next patch).

WBR, Sergei
Marek Vasut - April 18, 2012, 12:24 p.m.
Dear Sergei Shtylyov,

> Hello.
> 
> On 18-04-2012 6:07, Marek Vasut wrote:
> > Enable the second USB port on M28EVK board.
> > 
> > Signed-off-by: Marek Vasut<marex@denx.de>
> > Cc: Chen Peter-B29397<B29397@freescale.com>
> > Cc: Detlev Zundel<dzu@denx.de>
> > Cc: Fabio Estevam<festevam@gmail.com>
> > Cc: Li Frank-B20596<B20596@freescale.com>
> > Cc: Lin Tony-B19295<B19295@freescale.com>
> > Cc: Linux USB<linux-usb@vger.kernel.org>
> > Cc: Sascha Hauer<s.hauer@pengutronix.de>
> > Cc: Shawn Guo<shawn.guo@freescale.com>
> > Cc: Shawn Guo<shawn.guo@linaro.org>
> > Cc: Stefano Babic<sbabic@denx.de>
> > Cc: Subodh Nijsure<snijsure@grid-net.com>
> > Cc: Tony Lin<tony.lin@freescale.com>
> > Cc: Wolfgang Denk<wd@denx.de>
> > ---
> > 
> >   arch/arm/mach-mxs/Kconfig       |    2 ++
> >   arch/arm/mach-mxs/mach-m28evk.c |    9 +++++++++
> >   2 files changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
> > index 9dbf29f..5b5566c 100644
> > --- a/arch/arm/mach-mxs/Kconfig
> > +++ b/arch/arm/mach-mxs/Kconfig
> 
> [...]
> 
> > @@ -377,6 +382,10 @@ static void __init m28evk_init(void)
> > 
> >   	mx28_add_ts(&touch_pdata);
> >   	
> >   	mx28_add_gpmi_nand(&m28evk_gpmi_nand_data);
> > 
> > +
> > +	gpio_request_one(MXS_GPIO_NR(3, 13), GPIOF_OUT_INIT_LOW, "USB Power");
> 
>     Still can fail, and you don't handle it (unlike the next patch).

Hey, it was 4am in the morning when I was submitting this stuff, pardon my 
mistake ;-) Will be fixed in the new revision, thanks!

> 
> WBR, Sergei

Best regards,
Marek Vasut

Patch

diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig
index 9dbf29f..5b5566c 100644
--- a/arch/arm/mach-mxs/Kconfig
+++ b/arch/arm/mach-mxs/Kconfig
@@ -83,6 +83,8 @@  config MODULE_M28
 	select MXS_HAVE_PLATFORM_MXS_LRADC
 	select MXS_HAVE_PLATFORM_MXS_MMC
 	select MXS_HAVE_PLATFORM_MXSFB
+	select MXS_HAVE_PLATFORM_USB
+	select USB_ARCH_HAS_EHCI
 	select MXS_OCOTP
 
 config MODULE_APX4
diff --git a/arch/arm/mach-mxs/mach-m28evk.c b/arch/arm/mach-mxs/mach-m28evk.c
index f32fadb..ecdb0ff 100644
--- a/arch/arm/mach-mxs/mach-m28evk.c
+++ b/arch/arm/mach-mxs/mach-m28evk.c
@@ -212,6 +212,11 @@  static const iomux_cfg_t m28evk_pads[] __initconst = {
 
 	/* Backlight */
 	MX28_PAD_PWM3__GPIO_3_28 | MXS_PAD_CTRL,
+
+	/* USB */
+	MX28_PAD_SSP2_SS1__USB1_OVERCURRENT,
+	MX28_PAD_AUART3_TX__GPIO_3_13 |
+		MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP,
 };
 
 /* led */
@@ -377,6 +382,10 @@  static void __init m28evk_init(void)
 	mx28_add_ts(&touch_pdata);
 
 	mx28_add_gpmi_nand(&m28evk_gpmi_nand_data);
+
+	gpio_request_one(MXS_GPIO_NR(3, 13), GPIOF_OUT_INIT_LOW, "USB Power");
+
+	mx28_add_mxs_usbh(1);
 }
 
 static void __init m28evk_timer_init(void)