Message ID | 1334712587.11188.139.camel@minggr |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On 12-04-17 09:29 PM, Lin Ming wrote: > > I'm working on the hotplug issue fix. > > Before the fix is ready, here is the one-line patch. > Could you give it a try? .. > --- a/drivers/ata/libata-transport.c > +++ b/drivers/ata/libata-transport.c > @@ -294,6 +294,7 @@ int ata_tport_add(struct device *parent, > device_enable_async_suspend(dev); > pm_runtime_set_active(dev); > pm_runtime_enable(dev); > + pm_runtime_forbid(dev); > .. I'm rebuilding the kernel right now.. should take about 5min or less to test. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12-04-17 09:37 PM, Mark Lord wrote: > On 12-04-17 09:29 PM, Lin Ming wrote: >> >> I'm working on the hotplug issue fix. >> >> Before the fix is ready, here is the one-line patch. >> Could you give it a try? > .. >> --- a/drivers/ata/libata-transport.c >> +++ b/drivers/ata/libata-transport.c >> @@ -294,6 +294,7 @@ int ata_tport_add(struct device *parent, >> device_enable_async_suspend(dev); >> pm_runtime_set_active(dev); >> pm_runtime_enable(dev); >> + pm_runtime_forbid(dev); >> > .. > > I'm rebuilding the kernel right now.. should take about 5min or less to test. Yeah, that (by itself) is enough to make things work again. This looks like the one-liner that we really need upstream and in -stable. Jeff? I'll now use it instead of the (much larger) "v2 disable runtime pm" thing. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/17/2012 09:46 PM, Mark Lord wrote: > On 12-04-17 09:37 PM, Mark Lord wrote: >> On 12-04-17 09:29 PM, Lin Ming wrote: >>> >>> I'm working on the hotplug issue fix. >>> >>> Before the fix is ready, here is the one-line patch. >>> Could you give it a try? >> .. >>> --- a/drivers/ata/libata-transport.c >>> +++ b/drivers/ata/libata-transport.c >>> @@ -294,6 +294,7 @@ int ata_tport_add(struct device *parent, >>> device_enable_async_suspend(dev); >>> pm_runtime_set_active(dev); >>> pm_runtime_enable(dev); >>> + pm_runtime_forbid(dev); >>> >> .. >> >> I'm rebuilding the kernel right now.. should take about 5min or less to test. > > Yeah, that (by itself) is enough to make things work again. > This looks like the one-liner that we really need upstream and in -stable. > > Jeff? > > I'll now use it instead of the (much larger) "v2 disable runtime pm" thing. Yeah I like that a -whole- lot better... Will push upstream tomorrow. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c index 74aaee3..c341904 100644 --- a/drivers/ata/libata-transport.c +++ b/drivers/ata/libata-transport.c @@ -294,6 +294,7 @@ int ata_tport_add(struct device *parent, device_enable_async_suspend(dev); pm_runtime_set_active(dev); pm_runtime_enable(dev); + pm_runtime_forbid(dev); transport_add_device(dev); transport_configure_device(dev);