Patchwork [v2] iotests: fix error in 005

login
register
mail settings
Submitter Robert Wang
Date April 17, 2012, 8:23 a.m.
Message ID <1334651024-24479-1-git-send-email-wdongxu@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/153072/
State New
Headers show

Comments

Robert Wang - April 17, 2012, 8:23 a.m.
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>

According comment, we should not read again, we will write.

Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
---
v1 - v2: add 005.out

 tests/qemu-iotests/005     |    2 +-
 tests/qemu-iotests/005.out |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Stefan Hajnoczi - April 17, 2012, 8:56 a.m.
On Tue, Apr 17, 2012 at 9:23 AM, Dong Xu Wang
<wdongxu@linux.vnet.ibm.com> wrote:
> From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>
> According comment, we should not read again, we will write.
>
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> ---
> v1 - v2: add 005.out
>
>  tests/qemu-iotests/005     |    2 +-
>  tests/qemu-iotests/005.out |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Kevin Wolf - April 17, 2012, 9:28 a.m.
Am 17.04.2012 10:56, schrieb Stefan Hajnoczi:
> On Tue, Apr 17, 2012 at 9:23 AM, Dong Xu Wang
> <wdongxu@linux.vnet.ibm.com> wrote:
>> From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>>
>> According comment, we should not read again, we will write.
>>
>> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>> ---
>> v1 - v2: add 005.out
>>
>>  tests/qemu-iotests/005     |    2 +-
>>  tests/qemu-iotests/005.out |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

Kevin

Patch

diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005
index 74537db..b7970e3 100755
--- a/tests/qemu-iotests/005
+++ b/tests/qemu-iotests/005
@@ -65,7 +65,7 @@  $QEMU_IO -c "read 1024 4096" $TEST_IMG | _filter_qemu_io
 
 echo
 echo "small write"
-$QEMU_IO -c "read 8192 4096" $TEST_IMG | _filter_qemu_io
+$QEMU_IO -c "write 8192 4096" $TEST_IMG | _filter_qemu_io
 
 # success, all done
 echo "*** done"
diff --git a/tests/qemu-iotests/005.out b/tests/qemu-iotests/005.out
index 718a185..2d3e7df 100644
--- a/tests/qemu-iotests/005.out
+++ b/tests/qemu-iotests/005.out
@@ -8,6 +8,6 @@  read 4096/4096 bytes at offset 1024
 4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 
 small write
-read 4096/4096 bytes at offset 8192
+wrote 4096/4096 bytes at offset 8192
 4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 *** done