Patchwork iotests: fix error in 005

login
register
mail settings
Submitter Robert Wang
Date April 17, 2012, 6 a.m.
Message ID <1334642436-7461-1-git-send-email-wdongxu@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/153064/
State New
Headers show

Comments

Robert Wang - April 17, 2012, 6 a.m.
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>

According comment, we should not read again, we will write.

Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
---
 tests/qemu-iotests/005 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Paolo Bonzini - April 17, 2012, 7:45 a.m.
Il 17/04/2012 08:00, Dong Xu Wang ha scritto:
> From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> 
> According comment, we should not read again, we will write.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> ---
>  tests/qemu-iotests/005 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005
> index 74537db..b7970e3 100755
> --- a/tests/qemu-iotests/005
> +++ b/tests/qemu-iotests/005
> @@ -65,7 +65,7 @@ $QEMU_IO -c "read 1024 4096" $TEST_IMG | _filter_qemu_io
>  
>  echo
>  echo "small write"
> -$QEMU_IO -c "read 8192 4096" $TEST_IMG | _filter_qemu_io
> +$QEMU_IO -c "write 8192 4096" $TEST_IMG | _filter_qemu_io
>  
>  # success, all done
>  echo "*** done"

You need to regenerate 005.out:

small read
read 4096/4096 bytes at offset 1024
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

small write
read 4096/4096 bytes at offset 8192
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
*** done

Paolo

Patch

diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005
index 74537db..b7970e3 100755
--- a/tests/qemu-iotests/005
+++ b/tests/qemu-iotests/005
@@ -65,7 +65,7 @@  $QEMU_IO -c "read 1024 4096" $TEST_IMG | _filter_qemu_io
 
 echo
 echo "small write"
-$QEMU_IO -c "read 8192 4096" $TEST_IMG | _filter_qemu_io
+$QEMU_IO -c "write 8192 4096" $TEST_IMG | _filter_qemu_io
 
 # success, all done
 echo "*** done"