diff mbox

net/ipv4:Remove two memleak reports by kmemeleak_not_leak.

Message ID 201204171333149372727@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

majianpeng April 17, 2012, 5:33 a.m. UTC
From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Tue, 17 Apr 2012 13:29:55 +0800
Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.


Signed-off-by: majianpeng <majianpeng@gmail.com>
---
 net/ipv4/route.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Eric Dumazet April 17, 2012, 5:34 a.m. UTC | #1
On Tue, 2012-04-17 at 13:33 +0800, majianpeng wrote:
> From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 13:29:55 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
> 
> 
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
>  net/ipv4/route.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 167ea10..dd15648 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -3505,6 +3505,6 @@ int __init ip_rt_init(void)
>   */
>  void __init ip_static_sysctl_init(void)
>  {
> -	register_sysctl_paths(ipv4_path, ipv4_skeleton);
> +	kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
>  }
>  #endif

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller April 18, 2012, 4:22 a.m. UTC | #2
From: "majianpeng" <majianpeng@gmail.com>
Date: Tue, 17 Apr 2012 13:33:31 +0800

>>From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 13:29:55 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
> 
> 
> Signed-off-by: majianpeng <majianpeng@gmail.com>

I've applied both of your patches, but you are EXTREMELY careless
with your commit log messages and subject lines.

In this patch, and the net/core one, you misspell "kmemleak_not_leak"

In the net/core patch, you failed to separate "by" and "kmemleak_not_leak"
with a space in the Subject line.

Furthermore, it is extraneous to include the same From:, Date:, and
Subject: fields in the body of your email.  They are just fine in
your normal email headers.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 167ea10..dd15648 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -3505,6 +3505,6 @@  int __init ip_rt_init(void)
  */
 void __init ip_static_sysctl_init(void)
 {
-	register_sysctl_paths(ipv4_path, ipv4_skeleton);
+	kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
 }
 #endif