From patchwork Mon Apr 16 16:29:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiang Liu X-Patchwork-Id: 152937 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 93692B700D for ; Tue, 17 Apr 2012 02:33:42 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311Ab2DPQdm (ORCPT ); Mon, 16 Apr 2012 12:33:42 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:52165 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474Ab2DPQdl (ORCPT ); Mon, 16 Apr 2012 12:33:41 -0400 Received: by mail-pb0-f46.google.com with SMTP id un15so6539626pbc.19 for ; Mon, 16 Apr 2012 09:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=BAVOh9nPZDJWp2XVySoufWbhJxIQzSY+hHl9hpYwbio=; b=tfdAIGn1pp/1QKpPu0SmSCjmZpBLIklidXxHu9FPIorxOMJDeMnWbBx0uE96MVjuqB R0XZrvlxLH3NaUuRph9BuL6GF0RixmsV/Gwfi3qq6cBM91uNFmA+TNeKssdPIoYHlzgx RsD1Z+2oB3Nj5aaICzb1CWwQ36MAb2METJXbSUrh3S+3sqSJSfX2lBZpHlRcekjAiXO+ gwXkVMqC7DXIXXRQOfC/IXIGGdggjQaJMmKwOXfDPdO/RyXCyHT5pQGg9YTPuXGuiK0V YWsHVPrH86ZL1270+K0+UEjTCdm47xq/GJ4lFnET4InNhTql6AOfkMUssNBkZbGvIMsL 88Sg== Received: by 10.68.220.134 with SMTP id pw6mr28602036pbc.149.1334594021400; Mon, 16 Apr 2012 09:33:41 -0700 (PDT) Received: from localhost.localdomain ([221.221.22.162]) by mx.google.com with ESMTPS id v1sm18106794pbk.10.2012.04.16.09.33.34 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Apr 2012 09:33:40 -0700 (PDT) From: Jiang Liu To: Yinghai Lu , Kenji Kaneshige , Bjorn Helgaas , Scott Murray Cc: Jiang Liu , Jiang Liu , Keping Chen , linux-pci@vger.kernel.org Subject: [PATCH RFC 13/17] PCI: trivial code clean up in cpci_hotplug_core.c Date: Tue, 17 Apr 2012 00:29:07 +0800 Message-Id: <1334593751-5916-14-git-send-email-jiang.liu@huawei.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1334593751-5916-1-git-send-email-jiang.liu@huawei.com> References: <1334593751-5916-1-git-send-email-jiang.liu@huawei.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org 1) get rid of redundant lock operations in cpcihp_core. 2) return suitable error code instead of -1. Signed-off-by: Jiang Liu --- drivers/pci/hotplug/cpci_hotplug_core.c | 16 +++------------- 1 files changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/pci/hotplug/cpci_hotplug_core.c b/drivers/pci/hotplug/cpci_hotplug_core.c index 3fadf2f..7898023 100644 --- a/drivers/pci/hotplug/cpci_hotplug_core.c +++ b/drivers/pci/hotplug/cpci_hotplug_core.c @@ -304,7 +304,7 @@ cpci_hp_unregister_bus(struct pci_bus *bus) down_write(&list_rwsem); if (!slots) { up_write(&list_rwsem); - return -1; + return -ENODEV; } list_for_each_entry_safe(slot, tmp, &slot_list, slot_list) { if (slot->bus == bus) { @@ -357,11 +357,6 @@ init_slots(int clear_ins) struct pci_dev* dev; dbg("%s - enter", __func__); - down_read(&list_rwsem); - if (!slots) { - up_read(&list_rwsem); - return -1; - } list_for_each_entry(slot, &slot_list, slot_list) { dbg("%s - looking at slot %s", __func__, slot_name(slot)); if (clear_ins && cpci_check_and_clear_ins(slot)) @@ -376,7 +371,6 @@ init_slots(int clear_ins) slot->dev = dev; } } - up_read(&list_rwsem); dbg("%s - exit", __func__); return 0; } @@ -585,7 +579,7 @@ cpci_hp_register_controller(struct cpci_hp_controller *new_controller) int status = 0; if (controller) - return -1; + return -EBUSY; if (!(new_controller && new_controller->ops)) return -EINVAL; if (new_controller->irq) { @@ -620,15 +614,11 @@ cleanup_slots(void) * and free up all memory that we had allocated. */ down_write(&list_rwsem); - if (!slots) - goto cleanup_null; list_for_each_entry_safe(slot, tmp, &slot_list, slot_list) { list_del(&slot->slot_list); pci_hp_deregister(slot->hotplug_slot); } -cleanup_null: up_write(&list_rwsem); - return; } int @@ -663,9 +653,9 @@ cpci_hp_start(void) up_read(&list_rwsem); return -ENODEV; } + status = init_slots(first); up_read(&list_rwsem); - status = init_slots(first); if (first) first = 0; if (status)