Patchwork [SRU/Natty-Oneiric] drm/i915: Fixes distorted external screen image on HP 2730p

login
register
mail settings
Submitter Herton Ronaldo Krzesinski
Date April 16, 2012, 3:29 p.m.
Message ID <1334590147-5894-2-git-send-email-herton.krzesinski@canonical.com>
Download mbox | patch
Permalink /patch/152893/
State New
Headers show

Comments

Herton Ronaldo Krzesinski - April 16, 2012, 3:29 p.m.
From: Philipp Grete <mail@pgrete.de>

Fixes LP: #796030 by removing forced pipe A on HP 2730p.  Quirk has
previously been introduced to fix a sleep mode problem that does not
exist any more.

v2: Added Tested-by and Bugzilla Link
[herton - removed Bugzilla, replaced with BugLink]

BugLink: http://bugs.launchpad.net/bugs/796030
Tested-by: Ronny Standtke <ronny.standtke@gmx.net>
Signed-off-by: Philipp Grete <mail@pgrete.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
(backported from commit d12d04512c4430e29daede7f24b97f83f8cf259a upstream)
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Leann Ogasawara - April 16, 2012, 3:36 p.m.
On Mon, 2012-04-16 at 12:29 -0300, Herton Ronaldo Krzesinski wrote:
> From: Philipp Grete <mail@pgrete.de>
> 
> Fixes LP: #796030 by removing forced pipe A on HP 2730p.  Quirk has
> previously been introduced to fix a sleep mode problem that does not
> exist any more.
> 
> v2: Added Tested-by and Bugzilla Link
> [herton - removed Bugzilla, replaced with BugLink]
> 
> BugLink: http://bugs.launchpad.net/bugs/796030
> Tested-by: Ronny Standtke <ronny.standtke@gmx.net>
> Signed-off-by: Philipp Grete <mail@pgrete.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> (backported from commit d12d04512c4430e29daede7f24b97f83f8cf259a upstream)
> Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>

Given the positive feedback in the bug report and the low risk of
regression:

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2c8a234..03d56ae 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6891,8 +6891,6 @@ struct intel_quirk {
>  };
>  
>  struct intel_quirk intel_quirks[] = {
> -	/* HP Compaq 2730p needs pipe A force quirk (LP: #291555) */
> -	{ 0x2a42, 0x103c, 0x30eb, quirk_pipea_force },
>  	/* HP Mini needs pipe A force quirk (LP: #322104) */
>  	{ 0x27ae,0x103c, 0x361a, quirk_pipea_force },
>  
> -- 
> 1.7.5.4
> 
>

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2c8a234..03d56ae 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6891,8 +6891,6 @@  struct intel_quirk {
 };
 
 struct intel_quirk intel_quirks[] = {
-	/* HP Compaq 2730p needs pipe A force quirk (LP: #291555) */
-	{ 0x2a42, 0x103c, 0x30eb, quirk_pipea_force },
 	/* HP Mini needs pipe A force quirk (LP: #322104) */
 	{ 0x27ae,0x103c, 0x361a, quirk_pipea_force },