Patchwork debugfs: cleanup in do_show_debugfs_params

login
register
mail settings
Submitter Zheng Liu
Date April 16, 2012, 1:41 p.m.
Message ID <1334583686-4571-1-git-send-email-wenqing.lz@taobao.com>
Download mbox | patch
Permalink /patch/152860/
State Accepted
Headers show

Comments

Zheng Liu - April 16, 2012, 1:41 p.m.
From: Zheng Liu <wenqing.lz@taobao.com>

Remove 'out' variable and replace fprintf with printf.

Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
 debugfs/debugfs.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
Steven Liu - April 16, 2012, 2:21 p.m.
Hi Zheng Liu,

      What dose this mean, you use printf and not use stdout?


Reviewed-By Steven Liu <LiuQi@zecloud.cn>

2012/4/16 Zheng Liu <gnehzuil.liu@gmail.com>:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> Remove 'out' variable and replace fprintf with printf.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
>  debugfs/debugfs.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 590468d..99281ac 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -1973,12 +1973,10 @@ void do_rmdir(int argc, char *argv[])
>  void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
>                            char *argv[] EXT2FS_ATTR((unused)))
>  {
> -       FILE *out = stdout;
> -
>        if (current_fs)
> -               fprintf(out, "Open mode: read-%s\n",
> +               printf("Open mode: read-%s\n",
>                        current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
> -       fprintf(out, "Filesystem in use: %s\n",
> +       printf("Filesystem in use: %s\n",
>                current_fs ? current_fs->device_name : "--none--");
>  }
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Zheng Liu - April 16, 2012, 2:41 p.m.
On Mon, Apr 16, 2012 at 10:21:05PM +0800, Steven Liu wrote:
> Hi Zheng Liu,
> 
>       What dose this mean, you use printf and not use stdout?

printf() is the same as fprintf(stdout, ...).  So I just remove 'out'
variable.  Am I missing something?

Regards,
Zheng

> 
> 
> Reviewed-By Steven Liu <LiuQi@zecloud.cn>
> 
> 2012/4/16 Zheng Liu <gnehzuil.liu@gmail.com>:
> > From: Zheng Liu <wenqing.lz@taobao.com>
> >
> > Remove 'out' variable and replace fprintf with printf.
> >
> > Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> > ---
> >  debugfs/debugfs.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> > index 590468d..99281ac 100644
> > --- a/debugfs/debugfs.c
> > +++ b/debugfs/debugfs.c
> > @@ -1973,12 +1973,10 @@ void do_rmdir(int argc, char *argv[])
> >  void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
> >                            char *argv[] EXT2FS_ATTR((unused)))
> >  {
> > -       FILE *out = stdout;
> > -
> >        if (current_fs)
> > -               fprintf(out, "Open mode: read-%s\n",
> > +               printf("Open mode: read-%s\n",
> >                        current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
> > -       fprintf(out, "Filesystem in use: %s\n",
> > +       printf("Filesystem in use: %s\n",
> >                current_fs ? current_fs->device_name : "--none--");
> >  }
> >
> > --
> > 1.7.4.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - April 24, 2012, 6:33 p.m.
On Mon, Apr 16, 2012 at 09:41:26PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
> 
> Remove 'out' variable and replace fprintf with printf.
> 
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 590468d..99281ac 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -1973,12 +1973,10 @@  void do_rmdir(int argc, char *argv[])
 void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
 			    char *argv[] EXT2FS_ATTR((unused)))
 {
-	FILE *out = stdout;
-
 	if (current_fs)
-		fprintf(out, "Open mode: read-%s\n",
+		printf("Open mode: read-%s\n",
 			current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
-	fprintf(out, "Filesystem in use: %s\n",
+	printf("Filesystem in use: %s\n",
 		current_fs ? current_fs->device_name : "--none--");
 }