| Submitter | Hannes Eder |
|---|---|
| Date | Dec. 22, 2008, 7:16 p.m. |
| Message ID | <20081222191603.11807.61006.stgit@vmbox.hanneseder.net> |
| Download | mbox | patch |
| Permalink | /patch/15276/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Hannes Eder <hannes@hanneseder.net> Date: Mon, 22 Dec 2008 20:16:03 +0100 > The function 'vsc8211_set_speed_duplex' is not used, so comment it > out. For 'vsc8211_set_automdi' the function 'vsc8211_set_speed_duplex' > is the only caller, so comment it out as well. > > Fix this (sparse) warning: ... > Signed-off-by: Hannes Eder <hannes@hanneseder.net> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/net/cxgb3/vsc8211.c b/drivers/net/cxgb3/vsc8211.c index 33f956b..d071309 100644 --- a/drivers/net/cxgb3/vsc8211.c +++ b/drivers/net/cxgb3/vsc8211.c @@ -262,6 +262,7 @@ static int vsc8211_get_link_status_fiber(struct cphy *cphy, int *link_ok, return 0; } +#ifdef UNUSED /* * Enable/disable auto MDI/MDI-X in forced link speed mode. */ @@ -301,6 +302,7 @@ int vsc8211_set_speed_duplex(struct cphy *phy, int speed, int duplex) err = vsc8211_set_automdi(phy, 1); return err; } +#endif /* UNUSED */ static int vsc8211_power_down(struct cphy *cphy, int enable) {
The function 'vsc8211_set_speed_duplex' is not used, so comment it out. For 'vsc8211_set_automdi' the function 'vsc8211_set_speed_duplex' is the only caller, so comment it out as well. Fix this (sparse) warning: drivers/net/cxgb3/vsc8211.c:269: warning: 'vsc8211_set_automdi' defined but not used drivers/net/cxgb3/vsc8211.c:295:5: warning: symbol 'vsc8211_set_speed_duplex' was not declared. Should it be static? Signed-off-by: Hannes Eder <hannes@hanneseder.net> --- drivers/net/cxgb3/vsc8211.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html