From patchwork Mon Apr 16 04:36:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Lord X-Patchwork-Id: 152752 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-f184.google.com (mail-ob0-f184.google.com [209.85.214.184]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id CD344B6FF5 for ; Mon, 16 Apr 2012 14:36:22 +1000 (EST) Received: by obbta17 with SMTP id ta17sf416854obb.11 for ; Sun, 15 Apr 2012 21:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:x-ironport-anti-spam-filtered :x-ironport-anti-spam-result:x-ironport-av:message-id:date:from :user-agent:mime-version:to:subject:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=WvBab3IiIQ5soKZTBTTqCvUz2NV/rwkB07ky33OqlE4=; b=XLaMU0tOME8aKL0S9LRmgNPCpqXlynwyrhFdDMOKmtKPOe3TohM9yr+SPXTbYUI6b/ m2ej100eyyVjqfWrxNnwym/C5SMj8B86uvZQZq/jgHW5LsGN9pTEFkcd8C/ROip0fKUC yCZ3uInq9nRXUpQiR4WdTk4lJO+OeQodVIr/c= Received: by 10.50.95.136 with SMTP id dk8mr917763igb.0.1334550980183; Sun, 15 Apr 2012 21:36:20 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.231.80.74 with SMTP id s10ls7113707ibk.0.gmail; Sun, 15 Apr 2012 21:36:19 -0700 (PDT) Received: by 10.50.6.167 with SMTP id c7mr3779057iga.1.1334550979090; Sun, 15 Apr 2012 21:36:19 -0700 (PDT) Received: by 10.50.6.167 with SMTP id c7mr3779056iga.1.1334550979081; Sun, 15 Apr 2012 21:36:19 -0700 (PDT) Received: from ironport-out.teksavvy.com (ironport-out.teksavvy.com. [206.248.143.162]) by gmr-mx.google.com with ESMTP id ar8si4152194igc.2.2012.04.15.21.36.18; Sun, 15 Apr 2012 21:36:19 -0700 (PDT) Received-SPF: pass (google.com: domain of kernel@teksavvy.com designates 206.248.143.162 as permitted sender) client-ip=206.248.143.162; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuEBACxOgk8Y9geI/2dsb2JhbAANNoVzsCSGVgRRNgIFFgsCCwMCAQIBSwEMCAEBtCSKGIEvjhOBGASpJYE4Fg X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="174532466" Received: from 24-246-7-136.cable.teksavvy.com (HELO [10.0.0.2]) ([24.246.7.136]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-CAMELLIA256-SHA; 16 Apr 2012 00:36:18 -0400 Message-ID: <4F8BA1C1.4030804@teksavvy.com> Date: Mon, 16 Apr 2012 00:36:17 -0400 From: Mark Lord User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Linux Kernel , rtc-linux@googlegroups.com, Alessandro Zummo , Greg Kroah-Hartman , stable@vger.kernel.org Subject: [rtc-linux] [REGRESSION] rtc/interface.c: kills suspend-to-ram X-Original-Sender: kernel@teksavvy.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of kernel@teksavvy.com designates 206.248.143.162 as permitted sender) smtp.mail=kernel@teksavvy.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Something recent has killed suspend-to-ram on a number of machines here. The symptom is that they suspend, but immediately wake up and panic, with just a black screen so no visible messages to go by. The patch below works around the issue -- making things work as they used to work. Last known working kernel was 3.2.11. The line above got added somewhere between it and 3.2.15, and is also present (no surprise) in newer kernels. The highest kernel I've tested for this is 3.3.2, which also fails until I nuke the line shown above. This is straight x86_64 (Atom) hardware, using rtc-cmos. I can re-test if anyone has a fix for this. Meanwhile, whatever patch put this into -stable probably ought to be reverted upstream and in -stable as well. Cheers --- linux/drivers/rtc/interface.c.orig 2012-04-16 00:08:47.615389718 -0400 +++ linux/drivers/rtc/interface.c 2012-04-16 00:09:14.105387382 -0400 @@ -773,7 +773,7 @@ if (!rtc->ops || !rtc->ops->alarm_irq_enable) return; - rtc->ops->alarm_irq_enable(rtc->dev.parent, false); + //rtc->ops->alarm_irq_enable(rtc->dev.parent, false); // Kills suspend on ZBOX HD-ID41U } /**