Patchwork [Precise,SRU,0/3] comedi: correct default and max buffer size

login
register
mail settings
Submitter Leann Ogasawara
Date April 14, 2012, 8:14 p.m.
Message ID <cover.1334415251.git.leann.ogasawara@canonical.com>
Download mbox
Permalink /patch/152549/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/ogasawara/ubuntu-precise lp981234

Comments

Leann Ogasawara - April 14, 2012, 8:14 p.m.
From: Leann Ogasawara <leann.ogasawara@canonical.com>

== Precise SRU Justification ==

BugLink: http://bugs.launchpad.net/bugs/981234

The default and max buffer size are set to inappropriate values for the
comedi staging driver.  This results in program crashes.  Patches have
been submitted upstream to resolve this issue and are currently
available in:

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next

I have also received confirmation from the bug reporter and patch author
that they intend to submit these to upstream stable as well.  

The changes are limited to a single staging driver which should minimize
the risk of regression.  I have also received positive test confirmation
from the bug reporter that the patches noted below resolve the issue. 

== Fix ==
commit 4d7df821 from staging-next needed very minor fixing up when
cherry-picking.  commit 234bb3c6 from staging-next cherry-picked
cleanly.  The last commit updates the configs:

commit 4d7df821277e82ebe2fc9c9af07c928a83f572b8
Author: Ian Abbott <abbotti@mev.co.uk>
Date:   Fri Apr 13 14:12:53 2012 +0100

    staging: comedi: Add module parameters for default buffer size

commit 234bb3c60f1f1489630750aba4adf40154e0bd70
Author: Ian Abbott <abbotti@mev.co.uk>
Date:   Fri Apr 13 14:12:54 2012 +0100

    staging: comedi: Add kernel config for default buffer sizes

commit 96dddbbb8a9071cd1921575f864a5441fd7662a7
Author: Leann Ogasawara <leann.ogasawara@canonical.com>
Date:   Fri Apr 13 20:40:29 2012 -0700

    UBUNTU: [Config] Set CONFIG_COMEDI_DEFAULT_BUF_[SIZE_KB,MAXSIZE_KB]

I've also pushed these to a branch if you'd prefer to pull from there:

The following changes since commit 4767f8d1efe2d8bc94cf6d6937c0a0d5328e6e08:

  Linux 3.2.15 (2012-04-14 06:50:30 -0600)

are available in the git repository at:

  git://kernel.ubuntu.com/ogasawara/ubuntu-precise lp981234

for you to fetch changes up to 2bf208c4572e3ac2e7c364c4a26d4ecfd15e0412:

  UBUNTU: [Config] Set CONFIG_COMEDI_DEFAULT_BUF_[SIZE_KB,MAXSIZE_KB] (2012-04-14 13:05:43 -0700)

----------------------------------------------------------------
Ian Abbott (2):
      UBUNTU: SAUCE: staging: comedi: Add module parameters for default buffer size
      UBUNTU: SAUCE: staging: comedi: Add kernel config for default buffer sizes

Leann Ogasawara (1):
      UBUNTU: [Config] Set CONFIG_COMEDI_DEFAULT_BUF_[SIZE_KB,MAXSIZE_KB]

 debian.master/config/config.common.ubuntu |    2 ++
 drivers/staging/comedi/Kconfig            |   20 ++++++++++++++++++++
 drivers/staging/comedi/comedi_fops.c      |   27 ++++++++++++++++++++++++---
 drivers/staging/comedi/drivers.c          |   15 +++++++++------
 drivers/staging/comedi/internal.h         |    5 ++++-
 5 files changed, 59 insertions(+), 10 deletions(-)
Tim Gardner - April 15, 2012, 12:55 p.m.
I really should have waited for a 2nd ACK, but I kinda forgot. Besides, 
these are obvious fixes, and it _is_ for a staging driver. Note that I 
applied the [Config] patch first so that a bisection will build 
correctly if it lands on any of these 3 commits.

rtg