Patchwork [v2,07/14] target-arm: Drop JTAG_ID documentation

login
register
mail settings
Submitter Peter Maydell
Date April 14, 2012, 4:42 p.m.
Message ID <1334421743-31146-9-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/152525/
State New
Headers show

Comments

Peter Maydell - April 14, 2012, 4:42 p.m.
None of the machines in QEMU offer a JTAG debug interface, so this info
was unused. Further, the PXA250 ID contradicts the February 2002
Developer's Manual, which has it as 0xn9264013 with n the MIDR Revision.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/helper.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Andreas Färber - April 14, 2012, 5:23 p.m.
Am 14.04.2012 18:42, schrieb Peter Maydell:
> None of the machines in QEMU offer a JTAG debug interface, so this info
> was unused. Further, the PXA250 ID contradicts the February 2002
> Developer's Manual, which has it as 0xn9264013 with n the MIDR Revision.
> 

Signed-off-by: Andreas Färber <afaerber@suse.de>

> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---

Given that the commit message still is mine and only some parts of the
patch were dropped. ;)

Andreas

Patch

diff --git a/target-arm/helper.c b/target-arm/helper.c
index eab25ca..3e31f94 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -114,7 +114,6 @@  static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
     case ARM_CPUID_PXA260:
     case ARM_CPUID_PXA261:
     case ARM_CPUID_PXA262:
-        /* JTAG_ID is ((id << 28) | 0x09265013) */
         break;
     case ARM_CPUID_PXA270_A0:
     case ARM_CPUID_PXA270_A1:
@@ -122,7 +121,6 @@  static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
     case ARM_CPUID_PXA270_B1:
     case ARM_CPUID_PXA270_C0:
     case ARM_CPUID_PXA270_C5:
-        /* JTAG_ID is ((id << 28) | 0x09265013) */
         env->iwmmxt.cregs[ARM_IWMMXT_wCID] = 0x69051000 | 'Q';
         break;
     case ARM_CPUID_SA1100: