From patchwork Fri Apr 13 01:22:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Liu X-Patchwork-Id: 152235 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BD23DB7012 for ; Fri, 13 Apr 2012 11:16:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757561Ab2DMBQh (ORCPT ); Thu, 12 Apr 2012 21:16:37 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:39659 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757205Ab2DMBQg (ORCPT ); Thu, 12 Apr 2012 21:16:36 -0400 Received: by pbcun15 with SMTP id un15so3011855pbc.19 for ; Thu, 12 Apr 2012 18:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=FyxL+BvAAkLz7jReTg4uWJvR69qlqKfMXeZvIljBEfE=; b=GBM/kEay8vMwAIkKBEl3i6N/qgljXmwzGVPCOVjH31bxwGL2tFOUye/6BGMYw2R8Sm PgtoHu0rspDHHI2DI0wT0omC5i5O67GcBwRXE065ZSTnzRd3LH4BsWhFs0+flrNdevzu tS0EpkxlNinKkmoLcZl2VM9aAuBwCzWmIB6OMOTyly2SN/ZFIewSd14vc4O10TXuVYJO J0iU2ScV7Qwc0rfAryJZOZ95grHrUnG57Jkpb7z3qrgQ1KWZSeG4fUbi9cUXojaOddrn slnbzPpaLnDYneKLq+FXeEqZ06hdRIcp+OB8eQ8+hIiDqBTXBAtxAE2jkqtlEqAAZiUg 8VhA== Received: by 10.68.125.131 with SMTP id mq3mr158608pbb.123.1334279795917; Thu, 12 Apr 2012 18:16:35 -0700 (PDT) Received: from localhost.localdomain ([182.92.247.2]) by mx.google.com with ESMTPS id o9sm7165930pbe.60.2012.04.12.18.16.33 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Apr 2012 18:16:35 -0700 (PDT) From: Zheng Liu To: jack@suse.cz Cc: jouni.siren@iki.fi, linux-ext4@vger.kernel.org, Zheng Liu Subject: [PATCH RESEND] ext4: change return value from int to ssize_t in ext4_file_write Date: Fri, 13 Apr 2012 09:22:37 +0800 Message-Id: <1334280157-11630-1-git-send-email-wenqing.lz@taobao.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <20120412202029.GB19808@quack.suse.cz> References: <20120412202029.GB19808@quack.suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 64-platform, when we do a write operation with a huge number of data, it will cause that the ret variable overflows. So it is replaced with ssize_t. Reported-by: Jouni Siren Reviewed-by: Jan Kara Signed-off-by: Zheng Liu --- Hi Jan, You are right. I have changed the commit log. ;-) Regards, Zheng fs/ext4/file.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index cb70f18..8c7642a 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -95,7 +95,7 @@ ext4_file_write(struct kiocb *iocb, const struct iovec *iov, { struct inode *inode = iocb->ki_filp->f_path.dentry->d_inode; int unaligned_aio = 0; - int ret; + ssize_t ret; /* * If we have encountered a bitmap-format file, the size limit