From patchwork Thu Apr 12 22:40:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartley Sweeten X-Patchwork-Id: 152196 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1C533B7043 for ; Fri, 13 Apr 2012 08:40:54 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757920Ab2DLWkw (ORCPT ); Thu, 12 Apr 2012 18:40:52 -0400 Received: from mail160.messagelabs.com ([216.82.253.99]:36696 "EHLO mail160.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757869Ab2DLWkw (ORCPT ); Thu, 12 Apr 2012 18:40:52 -0400 X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-8.tower-160.messagelabs.com!1334270443!3697232!4 X-Originating-IP: [216.166.12.31] X-StarScan-Version: 6.5.7; banners=-,-,- X-VirusChecked: Checked Received: (qmail 9652 invoked from network); 12 Apr 2012 22:40:50 -0000 Received: from out001.collaborationhost.net (HELO out001.collaborationhost.net) (216.166.12.31) by server-8.tower-160.messagelabs.com with RC4-SHA encrypted SMTP; 12 Apr 2012 22:40:50 -0000 Received: from etch.local (10.2.3.210) by smtp.collaborationhost.net (10.2.0.46) with Microsoft SMTP Server (TLS) id 8.3.213.0; Thu, 12 Apr 2012 17:40:45 -0500 From: H Hartley Sweeten To: Linux Kernel Subject: [PATCH] ata: libata-eh.c: local functions should not be exposed globally Date: Thu, 12 Apr 2012 15:40:37 -0700 User-Agent: KMail/1.9.9 CC: , MIME-Version: 1.0 Content-Disposition: inline Message-ID: <201204121540.37253.hartleys@visionengravers.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The function ata_ering_clear_cb is only referenced in this file and should be marked static to prevent it from being exposed globally. This quiets the sparse warning: warning: symbol 'ata_ering_clear_cb' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Cc: Jeff Garzik --- -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index b02748b..1ae0417 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -419,7 +419,7 @@ int ata_ering_map(struct ata_ering *ering, return rc; } -int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg) +static int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg) { ent->eflags |= ATA_EFLAG_OLD_ER; return 0;