ata: libata-eh.c: local functions should not be exposed globally

Message ID
State Not Applicable
Delegated to: David Miller
Headers show

Commit Message

Hartley Sweeten April 12, 2012, 10:40 p.m.
The function ata_ering_clear_cb is only referenced in this file and
should be marked static to prevent it from being exposed globally.

This quiets the sparse warning:

warning: symbol 'ata_ering_clear_cb' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <>
Cc: Jeff Garzik <>


To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to
More majordomo info at


diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index b02748b..1ae0417 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -419,7 +419,7 @@  int ata_ering_map(struct ata_ering *ering,
 	return rc;
-int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg)
+static int ata_ering_clear_cb(struct ata_ering_entry *ent, void *void_arg)
 	ent->eflags |= ATA_EFLAG_OLD_ER;
 	return 0;