| Submitter | Andreas Schwab |
|---|---|
| Date | April 12, 2012, 8:20 p.m. |
| Message ID | <m2fwc8ya68.fsf@igel.home> |
| Download | mbox | patch |
| Permalink | /patch/152171/ |
| State | New |
| Headers | show |
Comments
Hi, > prettyprinters.exp is never run except in non-parallel check or when > requested explicitly. Tested on powerpc-linux and checked in as > obvious. Thanks Andreas. Since you seem to pay good attention to these testing details, I wonder if you could also help with the issue I noticed again over the last days with make check-performance not actually doing much if make check isn't run before. I bet a fix would turn out to be just a few lines.. Paolo
Paolo Carlini <pcarlini@gmail.com> writes: > Since you seem to pay good attention to these testing details, I wonder if > you could also help with the issue I noticed again over the last days with > make check-performance not actually doing much if make check isn't run > before. I bet a fix would turn out to be just a few lines.. Perhaps because # XXX Need to add dependency on libtestc++.a Andreas.
On 04/12/2012 11:43 PM, Andreas Schwab wrote: > Paolo Carlini<pcarlini@gmail.com> writes: > >> Since you seem to pay good attention to these testing details, I wonder if >> you could also help with the issue I noticed again over the last days with >> make check-performance not actually doing much if make check isn't run >> before. I bet a fix would turn out to be just a few lines.. > Perhaps because > # XXX Need to add dependency on libtestc++.a Indeed, I was looking for some sort of missing dependency... Any patchlet forthcoming for that? ;) Thanks, Paolo.
Patch
diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsuite/Makefile.am index 7094ad5..0cf8de5 100644 --- a/libstdc++-v3/testsuite/Makefile.am +++ b/libstdc++-v3/testsuite/Makefile.am @@ -134,7 +134,7 @@ check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.exp normal0) \ if $(SHELL) -c "$$runtest --version" > /dev/null 2>&1; then \ $$runtest $(AM_RUNTESTFLAGS) $(RUNTESTDEFAULTFLAGS) \ - $(RUNTESTFLAGS) abi.exp; \ + $(RUNTESTFLAGS) abi.exp prettyprinters.exp; \ else echo "WARNING: could not find \`runtest'" 1>&2; :;\ fi; \ dirs="`cd $$srcdir; echo [013-9][0-9]_*/*`";; \