Patchwork [net-next,3/4] caif-hsi: Remove stop/start of queue.

login
register
mail settings
Submitter sjur.brandeland@stericsson.com
Date April 12, 2012, 6:27 p.m.
Message ID <1334255247-3372-4-git-send-email-sjur.brandeland@stericsson.com>
Download mbox | patch
Permalink /patch/152160/
State Accepted
Delegated to: David Miller
Headers show

Comments

sjur.brandeland@stericsson.com - April 12, 2012, 6:27 p.m.
CAIF HSI is currently a virtual device. Stopping/starting the
queues is wrong on a virtual device.

Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
---

 drivers/net/caif/caif_hsi.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

Patch

diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c
index 9849a23..4253991 100644
--- a/drivers/net/caif/caif_hsi.c
+++ b/drivers/net/caif/caif_hsi.c
@@ -1129,15 +1129,11 @@  static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev)
 
 static int cfhsi_open(struct net_device *dev)
 {
-	netif_wake_queue(dev);
-
 	return 0;
 }
 
 static int cfhsi_close(struct net_device *dev)
 {
-	netif_stop_queue(dev);
-
 	return 0;
 }
 
@@ -1319,9 +1315,6 @@  int cfhsi_probe(struct platform_device *pdev)
 			__func__, res);
 		goto err_net_reg;
 	}
-
-	netif_stop_queue(ndev);
-
 	return res;
 
  err_net_reg:
@@ -1344,9 +1337,6 @@  static void cfhsi_shutdown(struct cfhsi *cfhsi)
 {
 	u8 *tx_buf, *rx_buf, *flip_buf;
 
-	/* Stop TXing */
-	netif_tx_stop_all_queues(cfhsi->ndev);
-
 	/* going to shutdown driver */
 	set_bit(CFHSI_SHUTDOWN, &cfhsi->bits);