From patchwork Thu Apr 12 16:44:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mjr@cs.wisc.edu X-Patchwork-Id: 152139 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2FC49B7037 for ; Fri, 13 Apr 2012 02:50:06 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757876Ab2DLQt7 (ORCPT ); Thu, 12 Apr 2012 12:49:59 -0400 Received: from sabe.cs.wisc.edu ([128.105.6.20]:47202 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667Ab2DLQt5 (ORCPT ); Thu, 12 Apr 2012 12:49:57 -0400 Received: from localhost.localdomain (71-90-102-157.dhcp.ftbg.wi.charter.com [71.90.102.157]) (authenticated bits=0) by sabe.cs.wisc.edu (8.14.1/8.14.1) with ESMTP id q3CGmZvp003609 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Apr 2012 11:49:02 -0500 From: mjr@cs.wisc.edu To: davem@davemloft.net Cc: sboyd@codeaurora.org, ben@simtec.co.uk, netdev@vger.kernel.org, Matt Renzelmann Subject: [PATCH] ks8851: Cancel any pending IRQ work Date: Thu, 12 Apr 2012 11:44:51 -0500 Message-Id: <1334249091-7605-1-git-send-email-mjr@cs.wisc.edu> X-Mailer: git-send-email 1.7.5.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Matt Renzelmann An unexpected/spurious interrupt may cause the irq_work queue to execute during or after module unload, which can cause a crash. It should be canceled. Signed-off-by: Matt Renzelmann --- drivers/net/ethernet/micrel/ks8851.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c index c722aa6..ab46953 100644 --- a/drivers/net/ethernet/micrel/ks8851.c +++ b/drivers/net/ethernet/micrel/ks8851.c @@ -1540,6 +1540,7 @@ static int __devexit ks8851_remove(struct spi_device *spi) dev_info(&spi->dev, "remove\n"); unregister_netdev(priv->netdev); + cancel_work_sync(&priv->irq_work); free_irq(spi->irq, priv); free_netdev(priv->netdev);