Message ID | 1334223234-23383-7-git-send-email-timo@exertus.fi |
---|---|
State | Changes Requested |
Delegated to: | Stefano Babic |
Headers | show |
Hi Timo, On Thu, Apr 12, 2012 at 6:33 AM, Timo Ketola <timo@exertus.fi> wrote: > Signed-off-by: Timo Ketola <timo@exertus.fi> > --- > boards.cfg | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks for your contributions. Please provide some more details in the commit message about this board, which peripherals are currently supported, where does it boot from, etc. Please also add an entry for your board in the MAINTAINERS file. You seem to have missed to do a "git add" for the files you introduced here ,ie, board/exertus/exe4026/ directory.
On 12.04.2012 13:43, Fabio Estevam wrote: > Please provide some more details in the commit message about this > board, which peripherals are currently supported, where does it boot > from, etc. > > Please also add an entry for your board in the MAINTAINERS file. > > You seem to have missed to do a "git add" for the files you introduced > here ,ie, board/exertus/exe4026/ directory. Yes, I will, but actually I didn't want to publish my board specific files and changes just yet. I committed all those changes into my git tree but now I don't know how to exclude this one (6/8, and perhaps 3/8) from git-send-email to send a cleaner series. I don't know either how to use git-send-email to send a single patch. I'll need to learn more about git - or can you or somebody here tell me right away? Do I perhaps have to create a second branch where I merge the relevant commits? -- Timo
On 12/04/2012 11:33, Timo Ketola wrote: > Signed-off-by: Timo Ketola <timo@exertus.fi> > --- > boards.cfg | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/boards.cfg b/boards.cfg > index 28cc345..44e80ed 100644 > --- a/boards.cfg > +++ b/boards.cfg > @@ -155,6 +155,7 @@ rd6281a arm arm926ejs - Marvell > sheevaplug arm arm926ejs - Marvell kirkwood > dockstar arm arm926ejs - Seagate kirkwood > jadecpu arm arm926ejs jadecpu syteco mb86r0x > +exe4026 arm arm926ejs exe4026 exertus mx25 exe4026:IMX_CONFIG=board/exertus/exe4026/imximage.cfg > mx25pdk arm arm926ejs mx25pdk freescale mx25 mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg > tx25 arm arm926ejs tx25 karo mx25 > zmx25 arm arm926ejs zmx25 syteco mx25 I assume you write also some code for this board. Maybe forgotten ? Best regards, Stefano Babic
On 12.04.2012 15:06, Stefano Babic wrote: >> +exe4026 arm arm926ejs exe4026 exertus mx25 exe4026:IMX_CONFIG=board/exertus/exe4026/imximage.cfg > > I assume you write also some code for this board. Maybe forgotten ? Yes, later. I have hard time with git-send-email selecting exactly what I want to send. -- Timo
On 12/04/2012 14:09, Timo Ketola wrote: > On 12.04.2012 15:06, Stefano Babic wrote: >>> +exe4026 arm arm926ejs >>> exe4026 exertus mx25 >>> exe4026:IMX_CONFIG=board/exertus/exe4026/imximage.cfg >> Hi Timo, >> I assume you write also some code for this board. Maybe forgotten ? > > Yes, later. I have hard time with git-send-email selecting exactly what > I want to send. If you don't already know, maybe this site can help: http://www.denx.de/wiki/U-Boot/Patches And if I understand what you are want, maybe the simple way is to add a branch and to cherry-pick (git cherry-pick) only the commit you want later send from your main branch. Then you can run "git format patch" to get the patchset. Please also add always a changelog in your patches, so we can easy find changes from previous versions. And please help us adding in CC the maintainer of the subsystem your patch is thought to change (me for i.MX related parts). Best regards, Stefano Babic
diff --git a/boards.cfg b/boards.cfg index 28cc345..44e80ed 100644 --- a/boards.cfg +++ b/boards.cfg @@ -155,6 +155,7 @@ rd6281a arm arm926ejs - Marvell sheevaplug arm arm926ejs - Marvell kirkwood dockstar arm arm926ejs - Seagate kirkwood jadecpu arm arm926ejs jadecpu syteco mb86r0x +exe4026 arm arm926ejs exe4026 exertus mx25 exe4026:IMX_CONFIG=board/exertus/exe4026/imximage.cfg mx25pdk arm arm926ejs mx25pdk freescale mx25 mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg tx25 arm arm926ejs tx25 karo mx25 zmx25 arm arm926ejs zmx25 syteco mx25
Signed-off-by: Timo Ketola <timo@exertus.fi> --- boards.cfg | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)