Patchwork Wimax - Makefile & Kconfig patch

login
register
mail settings
Submitter Sam Ravnborg
Date Dec. 21, 2008, 9:59 p.m.
Message ID <20081221215907.GA20856@uranus.ravnborg.org>
Download mbox | patch
Permalink /patch/15192/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Sam Ravnborg - Dec. 21, 2008, 9:59 p.m.
Hi Inaky.

Noticed your wimax patchset when I browsed netdev on marc.info.
A few comments:
Inaky Perez-Gonzalez - Dec. 22, 2008, 5:27 p.m.
On Sunday 21 December 2008, Sam Ravnborg wrote:
> Hi Inaky.
>
> Noticed your wimax patchset when I browsed netdev on marc.info.
> A few comments:

Thanks, I'll work on the changes.

Patch

diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index f19acf8..3ac378f 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -262,3 +262,4 @@  obj-$(CONFIG_NIU) += niu.o
 obj-$(CONFIG_VIRTIO_NET) += virtio_net.o
 obj-$(CONFIG_SFC) += sfc/
 
+obj-y += wimax/

There is no reason to visit this directory if WIMAX is
not enabled so change it to:

obj-$(CONFIG_WIMAX) += wimax/

diff --git a/drivers/net/wimax/i2400m/Kconfig b/drivers/net/wimax/i2400m/Kconfig
new file mode 100644
index 0000000..e977c46
--- /dev/null
+++ b/drivers/net/wimax/i2400m/Kconfig
@@ -0,0 +1,49 @@ 
+
+config WIMAX_I2400M
+        tristate
+	depends on WIMAX
+        select FW_LOADER
+

Above and in several other spots in the Kconfig
file you mix use of spaces and tabs for ident.
Please use tabs consistent and remember to indent
help text with:
<tab><space><space>

diff --git a/drivers/net/wimax/i2400m/Makefile b/drivers/net/wimax/i2400m/Makefile
new file mode 100644
index 0000000..2e8c15b
--- /dev/null
+++ b/drivers/net/wimax/i2400m/Makefile
@@ -0,0 +1,29 @@ 
+
+obj-$(CONFIG_WIMAX_I2400M) += i2400m.o
+obj-$(CONFIG_WIMAX_I2400M_USB) += i2400m-usb.o
+obj-$(CONFIG_WIMAX_I2400M_SDIO) += i2400m-sdio.o
+
+i2400m-objs :=		\
+	control.o	\
+	driver.o	\
+	fw.o		\
+	op-rfkill.o	\
+	netdev.o	\
+	tx.o		\
+	rx.o


It is recommended to use:

i2400m-y := control.o
i2400m-y += driver.o

The important point here is that -y is preferred over -objs.

If you use '\' or '+=' is more personal preferences.


	Sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html