Patchwork [Doc] Move paragraph about multiple attributes

login
register
mail settings
Submitter Tristan Gingold
Date April 11, 2012, 9:33 a.m.
Message ID <E0EFABED-3711-4887-9762-8FEE348734D8@adacore.com>
Download mbox | patch
Permalink /patch/151748/
State New
Headers show

Comments

Tristan Gingold - April 11, 2012, 9:33 a.m.
Hi,

this paragraph is inside the 'i386 type attributes' section, while it isn't target specific.

This patch moves it at the end of the attribute list.  Maybe we should remove it completely
as there is an 'attribute syntax' section.

Ok for trunk ?

Tristan.

2012-04-11  Tristan Gingold  <gingold@adacore.com>

	* doc/extend.texi (Type Attributes): Move paragraph.

index bb43825..c33ec66 100644
Richard Guenther - April 11, 2012, 10:03 a.m.
On Wed, Apr 11, 2012 at 11:33 AM, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
> this paragraph is inside the 'i386 type attributes' section, while it isn't target specific.
>
> This patch moves it at the end of the attribute list.  Maybe we should remove it completely
> as there is an 'attribute syntax' section.

I think it's good to have it repeated here.

> Ok for trunk ?

Ok.

Thanks,
Richard.

> Tristan.
>
> 2012-04-11  Tristan Gingold  <gingold@adacore.com>
>
>        * doc/extend.texi (Type Attributes): Move paragraph.
>
> index bb43825..c33ec66 100644
> --- a/gcc/doc/extend.texi
> +++ b/gcc/doc/extend.texi
> @@ -5372,6 +5372,10 @@ typeinfo node and exception handling will break.
>
>  @end table
>
> +To specify multiple attributes, separate them by commas within the
> +double parentheses: for example, @samp{__attribute__ ((aligned (16),
> +packed))}.
> +
>  @subsection ARM Type Attributes
>
>  On those ARM targets that support @code{dllimport} (such as Symbian
> @@ -5427,10 +5431,6 @@ Currently @option{-m[no-]ms-bitfields} is provided for the Microsoft Windows X86
>  compilers to match the native Microsoft compiler.
>  @end table
>
> -To specify multiple attributes, separate them by commas within the
> -double parentheses: for example, @samp{__attribute__ ((aligned (16),
> -packed))}.
> -
>  @anchor{PowerPC Type Attributes}
>  @subsection PowerPC Type Attributes
>
>
Tristan Gingold - April 11, 2012, 10:39 a.m.
On Apr 11, 2012, at 12:03 PM, Richard Guenther wrote:

> On Wed, Apr 11, 2012 at 11:33 AM, Tristan Gingold <gingold@adacore.com> wrote:
>> Hi,
>> 
>> this paragraph is inside the 'i386 type attributes' section, while it isn't target specific.
>> 
>> This patch moves it at the end of the attribute list.  Maybe we should remove it completely
>> as there is an 'attribute syntax' section.
> 
> I think it's good to have it repeated here.
> 
>> Ok for trunk ?
> 
> Ok.

Thanks, committed.

Tristan.

> 
> Thanks,
> Richard.
> 
>> Tristan.
>> 
>> 2012-04-11  Tristan Gingold  <gingold@adacore.com>
>> 
>>        * doc/extend.texi (Type Attributes): Move paragraph.
>> 
>> index bb43825..c33ec66 100644
>> --- a/gcc/doc/extend.texi
>> +++ b/gcc/doc/extend.texi
>> @@ -5372,6 +5372,10 @@ typeinfo node and exception handling will break.
>> 
>>  @end table
>> 
>> +To specify multiple attributes, separate them by commas within the
>> +double parentheses: for example, @samp{__attribute__ ((aligned (16),
>> +packed))}.
>> +
>>  @subsection ARM Type Attributes
>> 
>>  On those ARM targets that support @code{dllimport} (such as Symbian
>> @@ -5427,10 +5431,6 @@ Currently @option{-m[no-]ms-bitfields} is provided for the Microsoft Windows X86
>>  compilers to match the native Microsoft compiler.
>>  @end table
>> 
>> -To specify multiple attributes, separate them by commas within the
>> -double parentheses: for example, @samp{__attribute__ ((aligned (16),
>> -packed))}.
>> -
>>  @anchor{PowerPC Type Attributes}
>>  @subsection PowerPC Type Attributes
>> 
>>

Patch

--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -5372,6 +5372,10 @@  typeinfo node and exception handling will break.
 
 @end table
 
+To specify multiple attributes, separate them by commas within the
+double parentheses: for example, @samp{__attribute__ ((aligned (16),
+packed))}.
+
 @subsection ARM Type Attributes
 
 On those ARM targets that support @code{dllimport} (such as Symbian
@@ -5427,10 +5431,6 @@  Currently @option{-m[no-]ms-bitfields} is provided for the Microsoft Windows X86
 compilers to match the native Microsoft compiler.
 @end table
 
-To specify multiple attributes, separate them by commas within the
-double parentheses: for example, @samp{__attribute__ ((aligned (16),
-packed))}.
-
 @anchor{PowerPC Type Attributes}
 @subsection PowerPC Type Attributes