diff mbox

[U-Boot] driver/mtd:IFC: Fix possible memory leak

Message ID 1334134107-342-1-git-send-email-prabhakar@freescale.com
State Accepted
Commit 76d067ac33947f08fbbdea27bae5f3a263eda3f3
Delegated to: Scott Wood
Headers show

Commit Message

Prabhakar Kushwaha April 11, 2012, 8:48 a.m. UTC 
if priv->bank >= MAX_BANK, priv should be freed before returning ENODEV.

Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
 Based upon git://git.denx.de/u-boot.git branch master

 drivers/mtd/nand/fsl_ifc_nand.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Scott Wood May 18, 2012, 11:16 p.m. UTC | #1 
On Tue, Apr 10, 2012 at 10:48:27PM -0000, Prabhakar Kushwaha wrote:
> if priv->bank >= MAX_BANK, priv should be freed before returning ENODEV.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> 
> ---
> Based upon git://git.denx.de/u-boot.git branch master
> 
>  drivers/mtd/nand/fsl_ifc_nand.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied to u-boot-nand-flash

-Scott
diff mbox

Patch

diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index 7ff231b..5767a3e 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -764,6 +764,7 @@  int board_nand_init(struct nand_chip *nand)
 	if (priv->bank >= MAX_BANKS) {
 		printf("%s: address did not match any "
 		       "chip selects\n", __func__);
+		kfree(priv);
 		return -ENODEV;
 	}