Patchwork forcedeth: don't poll NV event 36

login
register
mail settings
Submitter Johannes Berg
Date Dec. 21, 2008, 7:44 p.m.
Message ID <1229888646.3050.4.camel@johannes>
Download mbox | patch
Permalink /patch/15172/
State Accepted
Delegated to: David Miller
Headers show

Comments

Johannes Berg - Dec. 21, 2008, 7:44 p.m.
Polling doesn't seem to be necessary on my hardware, at
least I haven't seen any bad effects testing it a while.
Remove the polling so the CPU doesn't have to wake up a
hundred times per second.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 drivers/net/forcedeth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 26, 2008, 2:08 a.m.
From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 21 Dec 2008 20:44:06 +0100

> Polling doesn't seem to be necessary on my hardware, at
> least I haven't seen any bad effects testing it a while.
> Remove the polling so the CPU doesn't have to wake up a
> hundred times per second.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Applied, thanks Johannes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- wireless-testing.orig/drivers/net/forcedeth.c	2008-12-21 13:01:14.000000000 +0100
+++ wireless-testing/drivers/net/forcedeth.c	2008-12-21 13:02:24.000000000 +0100
@@ -6141,7 +6141,7 @@  static struct pci_device_id pci_tbl[] = 
 	},
 	{	/* MCP79 Ethernet Controller */
 		PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_36),
-		.driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_LARGEDESC|DEV_HAS_CHECKSUM|DEV_HAS_HIGH_DMA|DEV_HAS_MSI|DEV_HAS_POWER_CNTRL|DEV_HAS_PAUSEFRAME_TX_V3|DEV_HAS_STATISTICS_V3|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR|DEV_HAS_COLLISION_FIX|DEV_NEED_TX_LIMIT|DEV_HAS_GEAR_MODE,
+		.driver_data = DEV_NEED_LINKTIMER|DEV_HAS_LARGEDESC|DEV_HAS_CHECKSUM|DEV_HAS_HIGH_DMA|DEV_HAS_MSI|DEV_HAS_POWER_CNTRL|DEV_HAS_PAUSEFRAME_TX_V3|DEV_HAS_STATISTICS_V3|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR|DEV_HAS_COLLISION_FIX|DEV_NEED_TX_LIMIT|DEV_HAS_GEAR_MODE,
 	},
 	{	/* MCP79 Ethernet Controller */
 		PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_37),