Patchwork tests: add test for symlink extent

login
register
mail settings
Submitter Andreas Dilger
Date April 10, 2012, 9:34 p.m.
Message ID <1334093657-32559-1-git-send-email-adilger@whamcloud.com>
Download mbox | patch
Permalink /patch/151697/
State Rejected
Headers show

Comments

Andreas Dilger - April 10, 2012, 9:34 p.m.
Long symlinks with the EXT4_EXTENTS_FL set may have been created at
one time due to the EXTENTS_FL being inherited from the parent dir.
While the original cause of such symlinks has been fixed in the
upstream kernel commit 2dc6b0d48ca0599837df21b14bb8393d0804af57,
such symlinks may still exist in the wild.

Add a test image that includes an extent symlink for sanity checks.

Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
---
 tests/f_extents_symlink/expect.1 |    7 +++++++
 tests/f_extents_symlink/expect.2 |    7 +++++++
 tests/f_extents_symlink/image.gz |  Bin 0 -> 617 bytes
 tests/f_extents_symlink/name     |    1 +
 4 files changed, 15 insertions(+), 0 deletions(-)
 create mode 100644 tests/f_extents_symlink/expect.1
 create mode 100644 tests/f_extents_symlink/expect.2
 create mode 100644 tests/f_extents_symlink/image.gz
 create mode 100644 tests/f_extents_symlink/name
Theodore Ts'o - April 11, 2012, 3:45 a.m.
On Tue, Apr 10, 2012 at 03:34:17PM -0600, Andreas Dilger wrote:
> Long symlinks with the EXT4_EXTENTS_FL set may have been created at
> one time due to the EXTENTS_FL being inherited from the parent dir.
> While the original cause of such symlinks has been fixed in the
> upstream kernel commit 2dc6b0d48ca0599837df21b14bb8393d0804af57,
> such symlinks may still exist in the wild.

Huh?  We're still creating long symlinks with extents, and I'm not
sure why this would be a problem.  I don't mind a test for it, but it
seems strange that (a) you think e2fsprogs wouldn't be able to deal
with it, and (b) that we aren't doing it any more.  I just tested with
a 3.3 kernel with the patches from the ext4's 3.4 merge window, and it
created a symlink with an extent.

See line 872 of fs/ext4/ialloc.c:

	if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) {
		/* set extent flag only for directory, file and normal symlink*/
		if (S_ISDIR(mode) || S_ISREG(mode) || S_ISLNK(mode)) {
			ext4_set_inode_flag(inode, EXT4_INODE_EXTENTS);
			ext4_ext_tree_init(handle, inode);
		}
	}

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andreas Dilger - April 11, 2012, 5:06 a.m.
On 2012-04-10, at 9:45 PM, Ted Ts'o wrote:
> On Tue, Apr 10, 2012 at 03:34:17PM -0600, Andreas Dilger wrote:
>> Long symlinks with the EXT4_EXTENTS_FL set may have been created at
>> one time due to the EXTENTS_FL being inherited from the parent dir.
>> While the original cause of such symlinks has been fixed in the
>> upstream kernel commit 2dc6b0d48ca0599837df21b14bb8393d0804af57,
>> such symlinks may still exist in the wild.
> 
> Huh?  We're still creating long symlinks with extents, and I'm not
> sure why this would be a problem.  I don't mind a test for it, but it
> seems strange that (a) you think e2fsprogs wouldn't be able to deal
> with it, and (b) that we aren't doing it any more.  I just tested with
> a 3.3 kernel with the patches from the ext4's 3.4 merge window, and it
> created a symlink with an extent.

My bad.  I had examined some symlinks on an ext4 filesystem to see if they had the EXT4_EXTENTS_FL set, but didn't think to check long symlinks, so I assumed this was an anachronism and rewrote the patch description while submitting it...  Originally it read:

    Long symlinks with the EXT4_EXTENTS_FL set should no longer be
    considered as corrupt, since these are created by default with
    new kernels using ext4 as the filesystem type.  This has not
    impacted Lustre in the past because extents are only enabled on
    the OST, while symlinks are only created on the MDT where extents
    are never enabled.
    
    However, now that distros are using ext4 as the base filesystem
    type, if the lustre-patched e2fsprogs RPM is installed it will
    incorrectly consider all such long symlinks as bad and remove them.

We had previously hit problems with Lustre e2fsprogs because we originally flagged such symlinks as errors, and there was no existing test which had such a symlink.  The description clearly wasn't useful for upstream submission, but the test is still useful.

Cheers, Andreas

> See line 872 of fs/ext4/ialloc.c:
> 
> 	if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) {
> 		/* set extent flag only for directory, file and normal symlink*/
> 		if (S_ISDIR(mode) || S_ISREG(mode) || S_ISLNK(mode)) {
> 			ext4_set_inode_flag(inode, EXT4_INODE_EXTENTS);
> 			ext4_ext_tree_init(handle, inode);
> 		}
> 	}
> 
> 						- Ted


Cheers, Andreas
--
Andreas Dilger                       Whamcloud, Inc.
Principal Lustre Engineer            http://www.whamcloud.com/




--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - April 11, 2012, 6:07 p.m.
On Tue, Apr 10, 2012 at 11:06:50PM -0600, Andreas Dilger wrote:
> 
> My bad.  I had examined some symlinks on an ext4 filesystem to see
> if they had the EXT4_EXTENTS_FL set, but didn't think to check long
> symlinks, so I assumed this was an anachronism and rewrote the patch
> description while submitting it...  Originally it read:
> 
>     Long symlinks with the EXT4_EXTENTS_FL set should no longer be
>     considered as corrupt, since these are created by default with
>     new kernels using ext4 as the filesystem type.  This has not
>     impacted Lustre in the past because extents are only enabled on
>     the OST, while symlinks are only created on the MDT where extents
>     are never enabled.
>     
>     However, now that distros are using ext4 as the base filesystem
>     type, if the lustre-patched e2fsprogs RPM is installed it will
>     incorrectly consider all such long symlinks as bad and remove them.
> 
> We had previously hit problems with Lustre e2fsprogs because we
> originally flagged such symlinks as errors, and there was no
> existing test which had such a symlink.  The description clearly
> wasn't useful for upstream submission, but the test is still useful.

OK, I'll update the commit description and give it a try.  Note that
one of the reasons why we *have* to support extent-mapped long
symlinks is for file systems with > 32-bit block numbers....

	    	     	     	    	   	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/tests/f_extents_symlink/expect.1 b/tests/f_extents_symlink/expect.1
new file mode 100644
index 0000000..4c5476c
--- /dev/null
+++ b/tests/f_extents_symlink/expect.1
@@ -0,0 +1,7 @@ 
+Pass 1: Checking inodes, blocks, and sizes
+Pass 2: Checking directory structure
+Pass 3: Checking directory connectivity
+Pass 4: Checking reference counts
+Pass 5: Checking group summary information
+test_filesys: 12/16 files (0.0% non-contiguous), 22/100 blocks
+Exit status is 0
diff --git a/tests/f_extents_symlink/expect.2 b/tests/f_extents_symlink/expect.2
new file mode 100644
index 0000000..4c5476c
--- /dev/null
+++ b/tests/f_extents_symlink/expect.2
@@ -0,0 +1,7 @@ 
+Pass 1: Checking inodes, blocks, and sizes
+Pass 2: Checking directory structure
+Pass 3: Checking directory connectivity
+Pass 4: Checking reference counts
+Pass 5: Checking group summary information
+test_filesys: 12/16 files (0.0% non-contiguous), 22/100 blocks
+Exit status is 0
diff --git a/tests/f_extents_symlink/image.gz b/tests/f_extents_symlink/image.gz
new file mode 100644
index 0000000000000000000000000000000000000000..797a9fa4f245e274cd49e67d207090ea3028923a
GIT binary patch
literal 617
zcmb2|=HLj|KkUoIoSB=Lp33m{#@=k<L>cxEr@OaoyZVdE@7CJpNmjc=GN<cp>u&BY
zIHH!@Y^tv2ba&O{M|zL0T|5}OaEg<-_<sg=aq;*C78)-WTv4CCg!k4$rK{6w?4C&L
zmHTsifAZ7z&Sw|F3v2sYra1An__RK8Hk!-ZHY;<>@34s3dyF=j&FpSle0si7=5AyE
zd%iBguQM-y`~J&W%vrCcXZtz%{~rnyzrJ2Nxj%m2PK%OXFBktWT>rj(zV9BdW7Fkq
z>i5=s{r6^X&hf2Z?8+RE2_*BM-kP;9^8Zhb)!qxTb8>j{<m&G;>^ikUuOaX1&VRYj
z<L&C#^sntP6H~C~%AUMe`K-yg^*ztbt}FGLmh`)umK}U__d}W8{QtFo(*ITI);N8C
zSGhX5_kaEFpZd~sUu9gEE;3lMe(Qcqfg+731t$`+<-cZ}*mx{%dEVWhzlt@xq=f6L
z-{qhGAN}?E>~sHX=NrGY3w^%t)fc|{#}8k1Z?CGVzFDG^zNz)><D6{)8GRp%1LMo=
zR$e`SPG$S*rO#%_cNEzgdrs>6d+g)ZM{BpRO)LI6@8=S$)$WP^U;JPCZ~v27U-?Tq
z_vkTv<zG?n@R#|Oe8B&PU+h=x7yM%c2{BL?{0pgF7u0=twZwV#t2cL)JwH~nw90m!
zYGLiVh<@#_JN6jF>P^pjSZp~@^V+NE+&r=6rwf<Pidz{nIViIH(7sQ?#zL3%7$z_>
F004Uf9en@*

literal 0
HcmV?d00001

diff --git a/tests/f_extents_symlink/name b/tests/f_extents_symlink/name
new file mode 100644
index 0000000..4aac4ac
--- /dev/null
+++ b/tests/f_extents_symlink/name
@@ -0,0 +1 @@ 
+long symlink with extents flag set